Skip to content

Commit 5197bd5

Browse files
committed
Merge remote-tracking branch 'remotes/origin/MAGETWO-51163' into PR-3
2 parents f513a16 + 497d6df commit 5197bd5

File tree

5 files changed

+3
-39
lines changed

5 files changed

+3
-39
lines changed

app/code/Magento/Catalog/Setup/CategorySetup.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Magento\Framework\App\CacheInterface;
1515
use Magento\Framework\Setup\ModuleDataSetupInterface;
1616
use Magento\Catalog\Model\Product\Type;
17-
use Magento\ConfigurableProduct\Model\Product\Type\Configurable;
1817

1918
class CategorySetup extends EavSetup
2019
{
@@ -598,7 +597,7 @@ public function getDefaultEntities()
598597
'filterable' => true,
599598
'comparable' => true,
600599
'visible_in_advanced_search' => true,
601-
'apply_to' => implode(',', [Type::TYPE_SIMPLE, Type::TYPE_VIRTUAL, Configurable::TYPE_CODE]),
600+
'apply_to' => implode(',', [Type::TYPE_SIMPLE, Type::TYPE_VIRTUAL]),
602601
'is_used_in_grid' => true,
603602
'is_visible_in_grid' => false,
604603
'is_filterable_in_grid' => true,

app/code/Magento/Catalog/Test/Unit/Model/Product/TypeTest.php

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,6 @@ public function testFactory()
142142

143143
public function testPriceFactory()
144144
{
145-
$this->assertInstanceOf(
146-
'\Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price',
147-
$this->_model->priceFactory('type_id_3')
148-
);
149-
$this->assertInstanceOf(
150-
'\Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price',
151-
$this->_model->priceFactory('type_id_3')
152-
);
153145
$this->assertInstanceOf(
154146
'\Magento\Catalog\Model\Product\Type\Price',
155147
$this->_model->priceFactory('type_id_1')
@@ -318,7 +310,7 @@ private function getMockedTypePriceFactory()
318310
->will(
319311
$this->returnValueMap(
320312
[
321-
['some_model', [], $this->getMockedProductTypeConfigurablePrice()],
313+
['some_model', [], $this->getMockedProductTypePrice()],
322314
['Magento\Catalog\Model\Product\Type\Price', [], $this->getMockedProductTypePrice()],
323315
]
324316
)
@@ -338,16 +330,4 @@ private function getMockedProductTypePrice()
338330

339331
return $mock;
340332
}
341-
342-
/**
343-
* @return \Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price
344-
*/
345-
private function getMockedProductTypeConfigurablePrice()
346-
{
347-
$mockBuild = $this->getMockBuilder('\Magento\ConfigurableProduct\Model\Product\Type\Configurable\Price')
348-
->disableOriginalConstructor();
349-
$mock = $mockBuild->getMock();
350-
351-
return $mock;
352-
}
353333
}

app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -818,21 +818,6 @@ public function testSaveAndDuplicate()
818818
$this->model->afterSave();
819819
}
820820

821-
public function testGetIsSalableConfigurable()
822-
{
823-
$typeInstanceMock = $this->getMock(
824-
'Magento\ConfigurableProduct\Model\Product\Type\Configurable', ['getIsSalable'], [], '', false);
825-
826-
$typeInstanceMock
827-
->expects($this->atLeastOnce())
828-
->method('getIsSalable')
829-
->willReturn(true);
830-
831-
$this->model->setTypeInstance($typeInstanceMock);
832-
833-
self::assertTrue($this->model->getIsSalable());
834-
}
835-
836821
public function testGetIsSalableSimple()
837822
{
838823
$typeInstanceMock =

app/code/Magento/Catalog/composer.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
"magento/module-config": "100.0.*",
2727
"magento/module-media-storage": "100.0.*",
2828
"magento/framework": "100.0.*",
29-
"magento/module-configurable-product": "100.0.*",
3029
"magento/module-ui": "100.0.*"
3130
},
3231
"suggest": {

app/code/Magento/ConfigurableProduct/Setup/InstallData.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface
5353
'special_to_date',
5454
'tier_price',
5555
'weight',
56+
'color'
5657
];
5758
foreach ($attributes as $attributeCode) {
5859
$relatedProductTypes = explode(

0 commit comments

Comments
 (0)