Fixed coding standard violations in the Framework\Test namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

- Removed @codingStandardsIgnoreFile from the head of the file
- Fixed indentation
- Removed duplicate code line in UrlTest class

Author: dverkade

lib/internal/Magento/Framework/Test/Unit/ShellTest.php

@@ -4,8 +4,6 @@
  * See COPYING.txt for license details.
  */
 
-// @codingStandardsIgnoreFile
-
 namespace Magento\Framework\Test\Unit;
 
 class ShellTest extends \PHPUnit_Framework_TestCase
@@ -54,7 +52,10 @@ protected function _testExecuteCommand(\Magento\Framework\Shell $shell, $command
     public function testExecute($command, $commandArgs, $expectedResult)
     {
         $this->_testExecuteCommand(
-            new \Magento\Framework\Shell($this->commandRenderer, $this->logger), $command, $commandArgs, $expectedResult
+            new \Magento\Framework\Shell($this->commandRenderer, $this->logger),
+            $command,
+            $commandArgs,
+            $expectedResult
         );
     }
 

lib/internal/Magento/Framework/Test/Unit/UrlTest.php

@@ -4,9 +4,8 @@
  * See COPYING.txt for license details.
  */
 
-// @codingStandardsIgnoreFile
-
 namespace Magento\Framework\Test\Unit;
+
 use Magento\Framework\Url\HostChecker;
 
 /**
@@ -125,7 +124,7 @@ protected function getRouteParamsResolverFactory($resolve = true)
         );
         if ($resolve) {
             $routeParamsResolverFactoryMock->expects($this->once())->method('create')
-                    ->will($this->returnValue($this->routeParamsResolverMock));
+                ->will($this->returnValue($this->routeParamsResolverMock));
         }
         return $routeParamsResolverFactoryMock;
     }
@@ -293,7 +292,6 @@ public function testGetUrlIdempotentSetRoutePath()
         $this->urlModifier->expects($this->exactly(1))->method('execute');
 
         $this->assertEquals('catalog/product/view', $model->getUrl('catalog/product/view'));
-        $this->assertEquals('catalog/product/view', $model->getUrl('catalog/product/view'));
     }
 
     public function testGetUrlIdempotentSetRouteName()
@@ -650,7 +648,8 @@ public function testGetConfigDataWithSecureIsForcedParam()
             ->method('getValue')
             ->with(
                 'web/secure/base_url_secure_forced',
-                \Magento\Store\Model\ScopeInterface::SCOPE_STORE, $this->scopeMock
+                \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+                $this->scopeMock
             )
             ->will($this->returnValue('http://localhost/'));
         $this->routeParamsResolverMock->expects($this->once())->method('hasData')->with('secure_is_forced')

lib/internal/Magento/Framework/Test/Unit/ValidatorFactoryTest.php

@@ -6,8 +6,6 @@
  * See COPYING.txt for license details.
  */
 
-// @codingStandardsIgnoreFile
-
 namespace Magento\Framework\Test\Unit;
 
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;