OptionToNumber method refactored:

- Removed option type validation
- Renamed into getOptionValue as it can be used for any option types

Author: vovayatsyuk

lib/web/mage/sticky.js

@@ -17,20 +17,12 @@ define([
             stickyClass: '_sticky'
         },
 
-        _optionToNumber: function (option) {
+        _getOptionValue: function (option) {
             var value = this.options[option] || 0;
             if (typeof value === 'function') {
                 value = this.options[option]();
             }
-
-            var converted = Number(value);
-            if (isNaN(converted)) {
-                throw Error(
-                    'sticky: Could not convert supplied option "' +
-                    option + '" to Number from "' + value + '"'
-                );
-            }
-            return converted;
+            return value;
         },
 
         /**
@@ -61,13 +53,13 @@ define([
             if (!isStatic && this.element.is(':visible')) {
                 offset = $(document).scrollTop()
                     - this.parentOffset
-                    + this._optionToNumber('spacingTop');
+                    + this._getOptionValue('spacingTop');
 
                 offset = Math.max(0, Math.min(offset, this.maxOffset));
 
                 var stuck = this.element.hasClass(this.options.stickyClass);
                 if (offset && this.options.offsetTop && !stuck) {
-                    var offsetTop = this._optionToNumber('offsetTop');
+                    var offsetTop = this._getOptionValue('offsetTop');
                     if (offset < offsetTop) {
                         offset = 0;
                     }