#CoreReview Improve test readability with const STUB and extracting assertions, using Phrase placeholder

Author: lbajsarowicz

dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/Category/Delete/DeleteCategoryWithEnabledFlatTest.php

@@ -24,6 +24,8 @@
  */
 class DeleteCategoryWithEnabledFlatTest extends AbstractBackendController
 {
+    const STUB_CATEGORY_ID = 333;
+
     /**
      * @var IndexerRegistry
      */
@@ -79,13 +81,16 @@ protected function tearDown()
      */
     public function testDeleteCategory(): void
     {
-        $this->assertEquals(1, $this->getFlatCategoryCollectionSizeByCategoryId(333));
-        $this->getRequest()->setMethod(HttpRequest::METHOD_POST);
-        $this->getRequest()->setPostValue(['id' => 333]);
-        $this->dispatch('backend/catalog/category/delete');
+        // Given
+        $this->assertEquals(1, $this->getFlatCategoryCollectionSizeByCategoryId(self::STUB_CATEGORY_ID));
+
+        // When
+        $this->sendDeleteCategoryRequest(self::STUB_CATEGORY_ID);
+
+        // Then
         $this->assertSessionMessages($this->equalTo([(string)__('You deleted the category.')]));
-        $this->assertEquals(0, $this->getFlatCategoryCollectionSizeByCategoryId(333));
-        $this->checkCategoryIsDeleted(333);
+        $this->assertEquals(0, $this->getFlatCategoryCollectionSizeByCategoryId(self::STUB_CATEGORY_ID));
+        $this->checkCategoryIsDeleted(self::STUB_CATEGORY_ID);
     }
 
     /**
@@ -106,10 +111,26 @@ private function getFlatCategoryCollectionSizeByCategoryId(int $categoryId): int
      * Assert that category is deleted.
      *
      * @param int $categoryId
+     * @return void
      */
     private function checkCategoryIsDeleted(int $categoryId): void
     {
-        $this->expectExceptionObject(new NoSuchEntityException(__("No such entity with id = {$categoryId}")));
+        $this->expectExceptionObject(
+            new NoSuchEntityException(__("No such entity with id = %entityId", ['entityId' => $categoryId]))
+        );
         $this->categoryRepository->get($categoryId);
     }
+
+    /**
+     * Method passes the request to Backend to remove given category.
+     *
+     * @param int $categoryId
+     * @return void
+     */
+    private function sendDeleteCategoryRequest(int $categoryId): void
+    {
+        $this->getRequest()->setMethod(HttpRequest::METHOD_POST);
+        $this->getRequest()->setPostValue(['id' => $categoryId]);
+        $this->dispatch('backend/catalog/category/delete');
+    }
 }