MC-31551: Category images are broken after migrating to 2.3.4

cpartica · cpartica · commit 4fe757d8c513 · 2020-02-21T16:32:02.000-06:00
- add excetion for phpcs
diff --git a/app/code/Magento/CatalogGraphQl/Model/Resolver/Category/Image.php b/app/code/Magento/CatalogGraphQl/Model/Resolver/Category/Image.php
@@ -81,11 +81,13 @@ public function resolve(
      */
     private function formatFileNameWithMediaCategoryFolder(string $fileName): string
     {
+        // phpcs:ignore Magento2.Functions.DiscouragedFunction
+        $baseFileName = basename($fileName);
         return '/'
             . $this->directoryList->getUrlPath('media')
             . '/'
             . ltrim(FileInfo::ENTITY_MEDIA_PATH, '/')
             . '/'
-            . basename($fileName);
+            . $baseFileName;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -81,11 +81,13 @@ public function resolve(`
`81`	`81`	`*/`
`82`	`82`	`private function formatFileNameWithMediaCategoryFolder(string $fileName): string`
`83`	`83`	`{`
	`84`	`+ // phpcs:ignore Magento2.Functions.DiscouragedFunction`
	`85`	`+ $baseFileName = basename($fileName);`
`84`	`86`	`return '/'`
`85`	`87`	`. $this->directoryList->getUrlPath('media')`
`86`	`88`	`. '/'`
`87`	`89`	`. ltrim(FileInfo::ENTITY_MEDIA_PATH, '/')`
`88`	`90`	`. '/'`
`89`		`- . basename($fileName);`
	`91`	`+ . $baseFileName;`
`90`	`92`	`}`
`91`	`93`	`}`