MAGETWO-28253: Downloadable Integration API

    - Fix static build errors

Author: Yu Tang

app/code/Magento/Downloadable/Model/LinkRepository.php

@@ -226,6 +226,7 @@ public function save($sku, LinkInterface $link, $isGlobalScopeContent = false)
      * @param \Magento\Catalog\Api\Data\ProductInterface $product
      * @param LinkInterface $link
      * @param bool $isGlobalScopeContent
+     * @return int
      */
     protected function saveLink(
         \Magento\Catalog\Api\Data\ProductInterface $product,

app/code/Magento/Downloadable/Model/SampleRepository.php

@@ -105,6 +105,12 @@ public function save(
         }
     }
 
+    /**
+     * @param \Magento\Catalog\Api\Data\ProductInterface $product
+     * @param SampleInterface $sample
+     * @param bool $isGlobalScopeContent
+     * @return int
+     */
     protected function saveSample(
         \Magento\Catalog\Api\Data\ProductInterface $product,
         SampleInterface $sample,
@@ -142,10 +148,12 @@ protected function saveSample(
     /**
      * @param \Magento\Catalog\Api\Data\ProductInterface $product
      * @param SampleInterface $sample
-     * @param $isGlobalScopeContent
-     * @return mixed
+     * @param bool $isGlobalScopeContent
+     * @return int
      * @throws InputException
      * @throws NoSuchEntityException
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     protected function updateSample(
         \Magento\Catalog\Api\Data\ProductInterface $product,

app/code/Magento/Downloadable/Test/Unit/Model/Link/ContentValidatorTest.php

@@ -52,7 +52,7 @@ protected function setUp()
         );
         $this->linkFileMock = $this->getMock('\Magento\Downloadable\Api\Data\File\ContentInterface');
         $this->sampleFileMock = $this->getMock('\Magento\Downloadable\Api\Data\File\ContentInterface');
-        $this->validator = new \Magento\Downloadable\Model\Link\ContentValidator($this->fileValidatorMock, $this->urlValidatorMock);
+        $this->validator = new ContentValidator($this->fileValidatorMock, $this->urlValidatorMock);
     }
 
     public function testIsValid()

app/code/Magento/Downloadable/Test/Unit/Model/Plugin/AroundProductRepositorySaveTest.php

@@ -266,9 +266,7 @@ public function testAroundSaveWithOnlyLinks()
     public function testAroundSaveWithOnlySamples()
     {
         $productSku = "downloadable_product";
-        $existingLinkId = '2';
         $existingSampleId = '5';
-        $toBeDeletedLinkId = '3';
         $toBeDeletedSampleId = '4';
 
         $this->productMock->expects($this->once())->method('getTypeId')

app/code/Magento/Downloadable/Test/Unit/Model/Product/TypeHandler/LinkTest.php

@@ -68,6 +68,7 @@ public function testSave($product, array $data, array $modelData)
 
     /**
      * @return array
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function saveDataProvider()
     {

app/code/Magento/Downloadable/Test/Unit/Model/Sample/ContentValidatorTest.php

@@ -51,7 +51,7 @@ protected function setUp()
             false
         );
         $this->sampleFileMock = $this->getMock('\Magento\Downloadable\Api\Data\File\ContentInterface');
-        $this->validator = new \Magento\Downloadable\Model\Sample\ContentValidator($this->fileValidatorMock, $this->urlValidatorMock);
+        $this->validator = new ContentValidator($this->fileValidatorMock, $this->urlValidatorMock);
     }
 
     public function testIsValid()

app/code/Magento/Downloadable/Test/Unit/Model/SampleRepositoryTest.php

@@ -201,7 +201,8 @@ public function testUpdate()
             '',
             false
         );
-        $this->sampleFactoryMock->expects($this->once())->method('create')->will($this->returnValue($existingSampleMock));
+        $this->sampleFactoryMock->expects($this->once())->method('create')
+            ->will($this->returnValue($existingSampleMock));
         $sampleMock = $this->getSampleMock($sampleData);
         $this->contentValidatorMock->expects($this->any())->method('isValid')->with($sampleMock)
             ->will($this->returnValue(true));
@@ -254,7 +255,8 @@ public function testUpdateThrowsExceptionIfTitleIsEmptyAndScopeIsGlobal()
         $existingSampleMock->expects($this->any())->method('getId')->will($this->returnValue($sampleId));
         $existingSampleMock->expects($this->once())->method('load')->with($sampleId)->will($this->returnSelf());
         $existingSampleMock->expects($this->any())->method('getProductId')->will($this->returnValue($productId));
-        $this->sampleFactoryMock->expects($this->once())->method('create')->will($this->returnValue($existingSampleMock));
+        $this->sampleFactoryMock->expects($this->once())->method('create')
+            ->will($this->returnValue($existingSampleMock));
         $sampleMock = $this->getSampleMock($sampleData);
         $this->contentValidatorMock->expects($this->any())->method('isValid')->with($sampleMock)
             ->will($this->returnValue(true));