MAGETWO-31559: [TD] Removing NominalItems usage

Author: Pechenushko

app/code/Magento/Checkout/Block/Total/Nominal.php

@@ -86,7 +86,6 @@ public function isMultishippingCheckoutAvailable()
             true
         ) &&
             $quote->getItemsSummaryQty() - $quote->getItemVirtualQty() > 0 &&
-            $quote->getItemsSummaryQty() <= $this->getMaximumQty() &&
-            !$quote->hasNominalItems();
+            $quote->getItemsSummaryQty() <= $this->getMaximumQty();
     }
 }

app/code/Magento/Checkout/etc/sales.xml

@@ -49,7 +49,7 @@ public function getAllItems()
                     'parent_item' => $item->getParentItem(),
                     'name' => $item->getName(),
                     'qty' => (int)$item->getTotalQty(),
-                    'price' => $item->isNominal() ? 0 : (double)$item->getBaseCalculationPrice(),
+                    'price' => (double)$item->getBaseCalculationPrice(),
                     'original_item' => $item,
                 ]
             );

app/code/Magento/Checkout/view/frontend/templates/total/nominal.phtml

@@ -81,9 +81,7 @@ public function isQuoteSummaryValid($isInCatalog)
     {
         $quote = $isInCatalog ? null : $this->_checkoutSession->getQuote();
         // validate minimum quote amount and validate quote for zero grandtotal
-        if (null !== $quote && (!$quote->validateMinimumAmount() ||
-            !$quote->getGrandTotal() && !$quote->hasNominalItems())
-        ) {
+        if (null !== $quote && (!$quote->validateMinimumAmount() || !$quote->getGrandTotal())) {
             return false;
         }
         return true;

app/code/Magento/Multishipping/Helper/Data.php

@@ -485,7 +485,7 @@ public function start($returnUrl, $cancelUrl, $button = null)
     {
         $this->_quote->collectTotals();
 
-        if (!$this->_quote->getGrandTotal() && !$this->_quote->hasNominalItems()) {
+        if (!$this->_quote->getGrandTotal()) {
             throw new \Magento\Framework\Model\Exception(
                 __(
                     'PayPal can\'t process orders with a zero balance due. '
@@ -563,7 +563,7 @@ public function start($returnUrl, $cancelUrl, $button = null)
             && $this->_config->getConfigValue('transferShippingOptions')
             && !empty($cartItems)
         ) {
-            if (!$this->_quote->getIsVirtual() && !$this->_quote->hasNominalItems()) {
+            if (!$this->_quote->getIsVirtual()) {
                 $options = $this->_prepareShippingOptions($address, true);
                 if ($options) {
                     $this->_api->setShippingOptionsCallbackUrl(
@@ -959,7 +959,7 @@ protected function _setExportedAddressData($address, $exportedAddress)
      */
     protected function _setBillingAgreementRequest()
     {
-        if (!$this->_customerId || $this->_quote->hasNominalItems()) {
+        if (!$this->_customerId) {
             return $this;
         }
 

app/code/Magento/Payment/Model/Cart/SalesModel/Quote.php

@@ -74,7 +74,6 @@ interface OrderItemInterface extends \Magento\Framework\Api\ExtensibleDataInterf
     const BASE_HIDDEN_TAX_INVOICED = 'base_hidden_tax_invoiced';
     const HIDDEN_TAX_REFUNDED = 'hidden_tax_refunded';
     const BASE_HIDDEN_TAX_REFUNDED = 'base_hidden_tax_refunded';
-    const IS_NOMINAL = 'is_nominal';
     const TAX_CANCELED = 'tax_canceled';
     const HIDDEN_TAX_CANCELED = 'hidden_tax_canceled';
     const TAX_REFUNDED = 'tax_refunded';
@@ -464,13 +463,6 @@ public function getHiddenTaxInvoiced();
      */
     public function getHiddenTaxRefunded();
 
-    /**
-     * Returns is_nominal
-     *
-     * @return int
-     */
-    public function getIsNominal();
-
     /**
      * Returns is_qty_decimal
      *

app/code/Magento/Paypal/Helper/Shortcut/CheckoutValidator.php

@@ -48,7 +48,7 @@ public function getTotalsRenderer($section, $group, $code)
 
     /**
      * Retrieve totals for group
-     * e.g. quote, nominal_totals, etc
+     * e.g. quote, etc
      *
      * @param string $section
      * @param string $group

app/code/Magento/Paypal/Model/Express/Checkout.php

@@ -4,7 +4,7 @@
  */
 
 /**
- * Converts sales totals (incl. nominal, creditmemo, invoice) from \DOMDocument to array
+ * Converts sales totals (incl. creditmemo, invoice) from \DOMDocument to array
  */
 namespace Magento\Sales\Model\Config;