Skip to content

Commit 4faa58f

Browse files
author
olysenko
committed
MAGETWO-63716: Add target to admin menu element
1 parent ed3cb39 commit 4faa58f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

app/code/Magento/Backend/Block/AnchorRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ public function __construct(
3838
/**
3939
* Render menu item anchor
4040
*
41-
* @param Item $activeItem
41+
* @param Item|null $activeItem
4242
* @param Item $menuItem
4343
* @param int $level
4444
* @return string
4545
*/
46-
public function renderAnchor(Item $activeItem, Item $menuItem, $level)
46+
public function renderAnchor($activeItem, Item $menuItem, $level)
4747
{
4848
if ($level == 1 && $menuItem->getUrl() == '#') {
4949
$output = '<strong class="submenu-group-title" role="presentation">'

app/code/Magento/Backend/Block/MenuItemChecker.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,20 @@ class MenuItemChecker
1515
/**
1616
* Check whether given item is currently selected
1717
*
18-
* @param Item $activeItem,
18+
* @param Item|null $activeItem,
1919
* @param Item $item
2020
* @param int $level
2121
* @return bool
2222
*/
2323
public function isItemActive(
24-
Item $activeItem,
24+
$activeItem,
2525
Item $item,
2626
$level
2727
) {
2828
$output = false;
2929

3030
if ($level == 0
31+
&& $activeItem instanceof \Magento\Backend\Model\Menu\Item
3132
&& $this->isActiveItemEqualOrChild($activeItem, $item)
3233
) {
3334
$output = true;

0 commit comments

Comments
 (0)