Skip to content

Commit 4f6aa75

Browse files
committed
Merge branch '2.3-develop-phpunit9' of https://github.com/magento-commerce/magento2ce into MC-39898
2 parents abcdcff + bfd1cb9 commit 4f6aa75

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/TranslationFiles.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class TranslationFiles extends \PHPUnit\Framework\TestCase
1515
*/
1616
protected $csvParser;
1717

18-
protected function setUp() : void
18+
protected function setUp(): void
1919
{
2020
$this->csvParser = new \Magento\Framework\File\Csv(new File());
2121
}

dev/tests/static/testsuite/Magento/Test/Legacy/LicenseTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function ($filename) {
2323

2424
foreach ($matches[0] as $commentText) {
2525
foreach (['Irubin Consulting Inc', 'DBA Varien', 'Magento Inc'] as $legacyText) {
26-
$this->assertNotContains(
26+
$this->assertStringNotContainsString(
2727
$legacyText,
2828
$commentText,
2929
"The license of file {$filename} contains legacy text."

dev/tests/static/testsuite/Magento/Test/Legacy/TableTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,12 @@ protected static function _matchesToInformation($content, $matches)
200200
* Composes information message based on list of legacy tables, found in a file
201201
*
202202
* @param array $legacyTables
203-
* @return null|string
203+
* @return string
204204
*/
205-
protected function _composeFoundsMessage($legacyTables)
205+
protected function _composeFoundsMessage($legacyTables): string
206206
{
207207
if (!$legacyTables) {
208-
return null;
208+
return '';
209209
}
210210

211211
$descriptions = [];

0 commit comments

Comments
 (0)