Skip to content

Commit 4ea7d62

Browse files
AnujNehraAnujNehra
AnujNehra
authored and
AnujNehra
committed
ACP2E-1776: Creating customer(-s) via Async REST API ignores group_id
1 parent a80effe commit 4ea7d62

File tree

2 files changed

+215
-0
lines changed

2 files changed

+215
-0
lines changed

‎app/code/Magento/Webapi/Test/Unit/Plugin/SyncRequestCustomerGroupAuthorizationTest.php

Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,103 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\Webapi\Test\Unit\Plugin;
9+
10+
use Magento\Customer\Api\CustomerRepositoryInterface;
11+
use Magento\Customer\Api\Data\CustomerInterface;
12+
use Magento\Customer\Model\AccountManagementApi;
13+
use Magento\Framework\Authorization;
14+
use Magento\Framework\Exception\AuthorizationException;
15+
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
16+
use Magento\Webapi\Plugin\SyncRequestCustomerGroupAuthorization;
17+
use PHPUnit\Framework\MockObject\MockObject;
18+
use PHPUnit\Framework\TestCase;
19+
20+
/**
21+
* Test for validating anonymous request for synchronous operations containing group id.
22+
*/
23+
class SyncRequestCustomerGroupAuthorizationTest extends TestCase
24+
{
25+
/**
26+
* @var Authorization|MockObject
27+
*/
28+
private $authorizationMock;
29+
30+
/**
31+
* @var SyncRequestCustomerGroupAuthorization
32+
*/
33+
private $plugin;
34+
35+
/**
36+
* @var AccountManagementApi
37+
*/
38+
private $accountManagementApiMock;
39+
40+
/**
41+
* @var CustomerRepositoryInterface|MockObject
42+
*/
43+
private $customerRepository;
44+
45+
/**
46+
* @inheritDoc
47+
*/
48+
protected function setUp(): void
49+
{
50+
$objectManager = new ObjectManager($this);
51+
$this->authorizationMock = $this->createMock(Authorization::class);
52+
$this->plugin = $objectManager->getObject(SyncRequestCustomerGroupAuthorization::class, [
53+
'authorization' => $this->authorizationMock
54+
]);
55+
$this->accountManagementApiMock = $this->createMock(AccountManagementApi::class);
56+
$this->customerRepository = $this->getMockForAbstractClass(CustomerRepositoryInterface::class);
57+
}
58+
59+
/**
60+
* Verify that only authorized request will be able to change groupId
61+
*
62+
* @param int $groupId
63+
* @param int $customerId
64+
* @param bool $isAllowed
65+
* @param int $willThrowException
66+
* @return void
67+
* @throws AuthorizationException
68+
* @dataProvider customerDataProvider
69+
*/
70+
public function testBeforeCreateAccount(
71+
int $groupId,
72+
int $customerId,
73+
bool $isAllowed,
74+
int $willThrowException
75+
): void {
76+
if ($willThrowException) {
77+
$this->expectException(AuthorizationException::class);
78+
} else {
79+
$this->expectNotToPerformAssertions();
80+
}
81+
$this->authorizationMock
82+
->expects($this->once())
83+
->method('isAllowed')
84+
->with('Magento_Customer::manage')
85+
->willReturn($isAllowed);
86+
$customer = $this->getMockForAbstractClass(CustomerInterface::class);
87+
$customer->method('getGroupId')->willReturn($groupId);
88+
$customer->method('getId')->willReturn($customerId);
89+
$this->customerRepository->method('getById')->with($customerId)->willReturn($customer);
90+
$this->plugin->beforeCreateAccount($this->accountManagementApiMock, $customer, '', '');
91+
}
92+
93+
/**
94+
* @return array
95+
*/
96+
public function customerDataProvider(): array
97+
{
98+
return [
99+
[3, 1, false, 1],
100+
[3, 1, true, 0]
101+
];
102+
}
103+
}

‎app/code/Magento/WebapiAsync/Test/Unit/Plugin/AsyncRequestCustomerGroupAuthorizationTest.php

Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,112 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
declare(strict_types=1);
7+
8+
namespace Magento\WebapiAsync\Test\Unit\Plugin;
9+
10+
use Magento\AsynchronousOperations\Model\MassSchedule;
11+
use Magento\Customer\Api\CustomerRepositoryInterface;
12+
use Magento\Customer\Api\Data\CustomerInterface;
13+
use Magento\Framework\Authorization;
14+
use Magento\Framework\Exception\AuthorizationException;
15+
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
16+
use Magento\WebapiAsync\Plugin\AsynchronousOperations\AsyncRequestCustomerGroupAuthorization;
17+
use PHPUnit\Framework\MockObject\MockObject;
18+
use PHPUnit\Framework\TestCase;
19+
20+
/**
21+
* Test for validating anonymous request for asynchronous operations containing group id.
22+
*/
23+
class AsyncRequestCustomerGroupAuthorizationTest extends TestCase
24+
{
25+
/**
26+
* @var Authorization|MockObject
27+
*/
28+
private $authorizationMock;
29+
30+
/**
31+
* @var AsyncRequestCustomerGroupAuthorization
32+
*/
33+
private $plugin;
34+
35+
/**
36+
* @var MassSchedule|MockObject
37+
*/
38+
private $massScheduleMock;
39+
40+
/**
41+
* @var CustomerRepositoryInterface|MockObject
42+
*/
43+
private $customerRepository;
44+
45+
/**
46+
* @inheritDoc
47+
*/
48+
protected function setUp(): void
49+
{
50+
$objectManager = new ObjectManager($this);
51+
$this->authorizationMock = $this->createMock(Authorization::class);
52+
$this->plugin = $objectManager->getObject(AsyncRequestCustomerGroupAuthorization::class, [
53+
'authorization' => $this->authorizationMock
54+
]);
55+
$this->massScheduleMock = $this->createMock(MassSchedule::class);
56+
$this->customerRepository = $this->getMockForAbstractClass(CustomerRepositoryInterface::class);
57+
}
58+
59+
/**
60+
* Verify that only authorized request will be able to change groupId
61+
*
62+
* @param int $groupId
63+
* @param int $customerId
64+
* @param bool $isAllowed
65+
* @param int $willThrowException
66+
* @return void
67+
* @throws AuthorizationException
68+
* @dataProvider customerDataProvider
69+
*/
70+
public function testBeforePublishMass(
71+
int $groupId,
72+
int $customerId,
73+
bool $isAllowed,
74+
int $willThrowException
75+
): void {
76+
if ($willThrowException) {
77+
$this->expectException(AuthorizationException::class);
78+
} else {
79+
$this->expectNotToPerformAssertions();
80+
}
81+
$customer = $this->getMockForAbstractClass(CustomerInterface::class);
82+
$customer->method('getGroupId')->willReturn($groupId);
83+
$customer->method('getId')->willReturn($customerId);
84+
$this->customerRepository->method('getById')->with($customerId)->willReturn($customer);
85+
$entitiesArray = [
86+
[$customer, 'Password1', '']
87+
];
88+
$this->authorizationMock
89+
->expects($this->once())
90+
->method('isAllowed')
91+
->with('Magento_Customer::manage')
92+
->willReturn($isAllowed);
93+
$this->plugin->beforePublishMass(
94+
$this->massScheduleMock,
95+
'async.magento.customer.api.accountmanagementinterface.createaccount.post',
96+
$entitiesArray,
97+
'',
98+
''
99+
);
100+
}
101+
102+
/**
103+
* @return array
104+
*/
105+
public function customerDataProvider(): array
106+
{
107+
return [
108+
[3, 1, false, 1],
109+
[3, 1, true, 0]
110+
];
111+
}
112+
}

0 commit comments

Comments
 (0)