MAGETWO-95595: Index names are ignored by declarative schema

Author: fascinosum

dev/tests/api-functional/_files/Magento/TestModuleDefaultHydrator/etc/db_schema.xml

@@ -11,10 +11,10 @@
         <column xsi:type="int" name="entity_id" padding="10" unsigned="true" nullable="false" identity="true"/>
         <column xsi:type="int" name="customer_id" padding="10" unsigned="true" nullable="false" identity="false"/>
         <column xsi:type="varchar" name="value" nullable="true" length="255"/>
-        <constraint xsi:type="primary" name="PRIMARY">
+        <constraint xsi:type="primary" referenceId="PRIMARY">
             <column name="entity_id"/>
         </constraint>
-        <constraint xsi:type="foreign" name="CSTR_EXTENSION_ATTR_ENTT_CSTR_ID_CSTR_ENTT_ENTT_ID"
+        <constraint xsi:type="foreign" referenceId="CSTR_EXTENSION_ATTR_ENTT_CSTR_ID_CSTR_ENTT_ENTT_ID"
                     table="testmodule_default_hydrator_extension_attribute_entity" column="customer_id"
                     referenceTable="customer_entity" referenceColumn="entity_id" onDelete="CASCADE"/>
     </table>

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule1/fixture/valid_xml_revision_1.php

@@ -225,17 +225,17 @@
                 ],
             ],
             'constraint' => [
-                'TEST_TABLE_SMALLINT_BIGINT' => [
+                'TEST_TABLE_UNIQUE' => [
                     'column' => [
                         'smallint' => 'smallint',
                         'bigint' => 'bigint',
                     ],
                     'type' => 'unique',
-                    'referenceId' => 'TEST_TABLE_SMALLINT_BIGINT',
+                    'referenceId' => 'TEST_TABLE_UNIQUE',
                 ],
-                'TEST_TABLE_TINYINT_REFERENCE_TABLE_TINYINT_REF' => [
+                'TEST_TABLE_TINYINT_REFERENCE' => [
                     'type' => 'foreign',
-                    'referenceId' => 'TEST_TABLE_TINYINT_REFERENCE_TABLE_TINYINT_REF',
+                    'referenceId' => 'TEST_TABLE_TINYINT_REFERENCE',
                     'column' => 'tinyint',
                     'table' => 'test_table',
                     'referenceTable' => 'reference_table',
@@ -244,12 +244,12 @@
                 ],
             ],
             'index' => [
-                'TEST_TABLE_TINYINT_BIGINT' => [
+                'TEST_TABLE_INDEX' => [
                     'column' => [
                         'tinyint' => 'tinyint',
                         'bigint' => 'bigint',
                     ],
-                    'referenceId' => 'TEST_TABLE_TINYINT_BIGINT',
+                    'referenceId' => 'TEST_TABLE_INDEX',
                     'indexType' => 'btree',
                 ],
             ],

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/MySQL/Definition/Constraints/ForeignKey.php

@@ -43,7 +43,6 @@ public function __construct(ResourceConnection $resourceConnection)
     }
 
     /**
-     * @param Reference $foreignKey
      * @inheritdoc
      */
     public function toDefinition(ElementInterface $foreignKey)