MCP-903: Fix default connection = db setting after Magento installation

- Update unit test;
- Remove db connection as a default for web api tests queues;

Author: adifucan

dev/tests/api-functional/config/post-install-setup-command-config.php.dist

@@ -6,15 +6,14 @@
 
 // List of bin/magento setup CLI commands to run after setup:install
 return [
+    /*
     [
         'command' => 'setup:config:set',
         'config' => [
-            '--queue-default-connection' => 'db'
-            /*
             '--remote-storage-driver' => 'aws-s3',
             '--remote-storage-bucket' => 'myBucket',
-            '--remote-storage-region' => 'us-east-1',
-            */
+            '--remote-storage-region' => 'us-east-1'
         ]
     ]
+    */
 ];

setup/src/Magento/Setup/Model/ConfigOptionsList/Lock.php

@@ -26,70 +26,70 @@ class Lock implements ConfigOptionsListInterface
      *
      * @const string
      */
-    const INPUT_KEY_LOCK_PROVIDER = 'lock-provider';
+    public const INPUT_KEY_LOCK_PROVIDER = 'lock-provider';
 
     /**
      * The name of an option to set DB prefix
      *
      * @const string
      */
-    const INPUT_KEY_LOCK_DB_PREFIX = 'lock-db-prefix';
+    public const INPUT_KEY_LOCK_DB_PREFIX = 'lock-db-prefix';
 
     /**
      * The name of an option to set Zookeeper host
      *
      * @const string
      */
-    const INPUT_KEY_LOCK_ZOOKEEPER_HOST = 'lock-zookeeper-host';
+    public const INPUT_KEY_LOCK_ZOOKEEPER_HOST = 'lock-zookeeper-host';
 
     /**
      * The name of an option to set Zookeeper path
      *
      * @const string
      */
-    const INPUT_KEY_LOCK_ZOOKEEPER_PATH = 'lock-zookeeper-path';
+    public const INPUT_KEY_LOCK_ZOOKEEPER_PATH = 'lock-zookeeper-path';
 
     /**
      * The name of an option to set File path
      *
      * @const string
      */
-    const INPUT_KEY_LOCK_FILE_PATH = 'lock-file-path';
+    public const INPUT_KEY_LOCK_FILE_PATH = 'lock-file-path';
 
     /**
      * The configuration path to save lock provider
      *
      * @const string
      */
-    const CONFIG_PATH_LOCK_PROVIDER = 'lock/provider';
+    public const CONFIG_PATH_LOCK_PROVIDER = 'lock/provider';
 
     /**
      * The configuration path to save DB prefix
      *
      * @const string
      */
-    const CONFIG_PATH_LOCK_DB_PREFIX = 'lock/config/prefix';
+    public const CONFIG_PATH_LOCK_DB_PREFIX = 'lock/config/prefix';
 
     /**
      * The configuration path to save Zookeeper host
      *
      * @const string
      */
-    const CONFIG_PATH_LOCK_ZOOKEEPER_HOST = 'lock/config/host';
+    public const CONFIG_PATH_LOCK_ZOOKEEPER_HOST = 'lock/config/host';
 
     /**
      * The configuration path to save Zookeeper path
      *
      * @const string
      */
-    const CONFIG_PATH_LOCK_ZOOKEEPER_PATH = 'lock/config/path';
+    public const CONFIG_PATH_LOCK_ZOOKEEPER_PATH = 'lock/config/path';
 
     /**
      * The configuration path to save locks directory path
      *
      * @const string
      */
-    const CONFIG_PATH_LOCK_FILE_PATH = 'lock/config/path';
+    public const CONFIG_PATH_LOCK_FILE_PATH = 'lock/config/path';
 
     /**
      * The list of lock providers

setup/src/Magento/Setup/Test/Unit/Model/ConfigOptionsList/LockTest.php

@@ -93,10 +93,7 @@ public function createConfigDataProvider(): array
                 'options' => [],
                 'expectedResult' => [
                     'lock' => [
-                        'provider' => LockBackendFactory::LOCK_DB,
-                        'config' => [
-                            'prefix' => null,
-                        ],
+                        'provider' => LockBackendFactory::LOCK_DB
                     ],
                 ],
             ],
@@ -168,6 +165,31 @@ public function createConfigDataProvider(): array
                     ],
                 ],
             ],
+            'Check specific db lock prefix null options' => [
+                'options' => [
+                    LockConfigOptionsList::INPUT_KEY_LOCK_PROVIDER => LockBackendFactory::LOCK_DB,
+                    LockConfigOptionsList::INPUT_KEY_LOCK_DB_PREFIX => null
+                ],
+                'expectedResult' => [
+                    'lock' => [
+                        'provider' => LockBackendFactory::LOCK_DB
+                    ],
+                ],
+            ],
+            'Check specific db lock prefix empty options' => [
+                'options' => [
+                    LockConfigOptionsList::INPUT_KEY_LOCK_PROVIDER => LockBackendFactory::LOCK_DB,
+                    LockConfigOptionsList::INPUT_KEY_LOCK_DB_PREFIX => ''
+                ],
+                'expectedResult' => [
+                    'lock' => [
+                        'provider' => LockBackendFactory::LOCK_DB,
+                        'config' => [
+                            'prefix' => '',
+                        ],
+                    ],
+                ],
+            ],
         ];
     }