#27948: Removed metadata pool

Author: sivaschenko

app/code/Magento/MediaContentCatalog/Observer/Category.php

@@ -13,8 +13,6 @@
 use Magento\MediaContentApi\Api\UpdateContentAssetLinksInterface;
 use Magento\MediaContentApi\Api\Data\ContentIdentityInterfaceFactory;
 use Magento\MediaContentCatalog\Model\ResourceModel\GetContent;
-use Magento\Framework\EntityManager\MetadataPool;
-use Magento\Catalog\Api\Data\CategoryInterface;
 
 /**
  * Observe the catalog_category_save_after event and run processing relation between category content and media asset.
@@ -26,11 +24,6 @@ class Category implements ObserverInterface
     private const ENTITY_ID = 'entityId';
     private const FIELD = 'field';
 
-    /**
-     * @var MetadataPool
-     */
-    private $metadataPool;
-
     /**
      * @var UpdateContentAssetLinksInterface
      */
@@ -61,13 +54,11 @@ public function __construct(
         ContentIdentityInterfaceFactory $contentIdentityFactory,
         GetContent $getContent,
         UpdateContentAssetLinksInterface $updateContentAssetLinks,
-        MetadataPool $metadataPool,
         array $fields
     ) {
         $this->contentIdentityFactory = $contentIdentityFactory;
         $this->getContent = $getContent;
         $this->updateContentAssetLinks = $updateContentAssetLinks;
-        $this->metadataPool = $metadataPool;
         $this->fields = $fields;
     }
 
@@ -82,7 +73,6 @@ public function execute(Observer $observer): void
         $model = $observer->getEvent()->getData('category');
 
         if ($model instanceof CatalogCategory) {
-            $id = (int) $model->getData($this->metadataPool->getMetadata(CategoryInterface::class)->getLinkField());
             foreach ($this->fields as $field) {
                 if (!$model->dataHasChangedFor($field)) {
                     continue;
@@ -95,7 +85,7 @@ public function execute(Observer $observer): void
                             self::ENTITY_ID => (string) $model->getId(),
                         ]
                     ),
-                    $this->getContent->execute($id, $model->getAttributes()[$field])
+                    $this->getContent->execute((int) $model->getId(), $model->getAttributes()[$field])
                 );
             }
         }

app/code/Magento/MediaContentCatalog/Observer/Product.php

@@ -13,8 +13,6 @@
 use Magento\MediaContentApi\Api\UpdateContentAssetLinksInterface;
 use Magento\MediaContentApi\Api\Data\ContentIdentityInterfaceFactory;
 use Magento\MediaContentCatalog\Model\ResourceModel\GetContent;
-use Magento\Framework\EntityManager\MetadataPool;
-use Magento\Catalog\Api\Data\ProductInterface;
 
 /**
  * Observe the catalog_product_save_after event and run processing relation between product content and media asset
@@ -26,11 +24,6 @@ class Product implements ObserverInterface
     private const ENTITY_ID = 'entityId';
     private const FIELD = 'field';
 
-    /**
-     * @var MetadataPool
-     */
-    private $metadataPool;
-
     /**
      * @var UpdateContentAssetLinksInterface
      */
@@ -61,10 +54,8 @@ public function __construct(
         ContentIdentityInterfaceFactory $contentIdentityFactory,
         GetContent $getContent,
         UpdateContentAssetLinksInterface $updateContentAssetLinks,
-        MetadataPool $metadataPool,
         array $fields
     ) {
-        $this->metadataPool = $metadataPool;
         $this->contentIdentityFactory = $contentIdentityFactory;
         $this->getContent = $getContent;
         $this->updateContentAssetLinks = $updateContentAssetLinks;
@@ -82,7 +73,6 @@ public function execute(Observer $observer): void
         $model = $observer->getEvent()->getData('product');
 
         if ($model instanceof CatalogProduct) {
-            $id = (int) $model->getData($this->metadataPool->getMetadata(ProductInterface::class)->getLinkField());
             foreach ($this->fields as $field) {
                 if (!$model->dataHasChangedFor($field)) {
                     continue;
@@ -95,7 +85,7 @@ public function execute(Observer $observer): void
                             self::ENTITY_ID => (string) $model->getId(),
                         ]
                     ),
-                    $this->getContent->execute($id, $model->getAttributes()[$field])
+                    $this->getContent->execute((int) $model->getId(), $model->getAttributes()[$field])
                 );
             }
         }