MAGETWO-28256: Bundle Integration API Refactoring

    - Fix bugs

Author: Yu Tang

app/code/Magento/Bundle/Api/ProductLinkManagementInterface.php

@@ -33,15 +33,15 @@ public function getChildren($productSku, $optionId = null);
     public function addChildByProductSku($sku, $optionId, \Magento\Bundle\Api\Data\LinkInterface $linkedProduct);
 
     /**
-     * @param string $sku
+     * @param string $productSku
      * @param \Magento\Bundle\Api\Data\LinkInterface $linkedProduct
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      * @throws \Magento\Framework\Exception\CouldNotSaveException
      * @throws \Magento\Framework\Exception\InputException
      * @return bool
      */
     public function saveChild(
-        $sku,
+        $productSku,
         \Magento\Bundle\Api\Data\LinkInterface $linkedProduct
     );
 

app/code/Magento/Bundle/Model/LinkManagement.php

@@ -111,10 +111,10 @@ public function addChildByProductSku($sku, $optionId, \Magento\Bundle\Api\Data\L
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function saveChild(
-        $sku,
+        $productSku,
         \Magento\Bundle\Api\Data\LinkInterface $linkedProduct
     ) {
-        $product = $this->productRepository->get($sku);
+        $product = $this->productRepository->get($productSku);
         if ($product->getTypeId() != \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE) {
             throw new InputException(
                 __('Product with specified sku: "%1" is not a bundle product', [$product->getSku()])

app/code/Magento/Bundle/Model/OptionRepository.php

@@ -178,7 +178,6 @@ public function save(
             }
         } else {
             $optionCollection = $this->type->getOptionsCollection($product);
-            $optionCollection->setIdFilter($option->getOptionId());
 
             /** @var \Magento\Bundle\Model\Option $existingOption */
             $existingOption = $optionCollection->getItemById($option->getOptionId());

app/code/Magento/Bundle/Test/Unit/Model/OptionRepositoryTest.php

@@ -335,7 +335,6 @@ public function testUpdateIfOptionDoesNotExist()
             ->willReturn($optCollectionMock);
 
         $existingOptionMock = $this->getMock('\Magento\Bundle\Model\Option', ['getOptionId'], [], '', false);
-        $optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
         $optCollectionMock->expects($this->once())->method('getItemById')
             ->with($optionId)
             ->willReturn($existingOptionMock);
@@ -407,7 +406,6 @@ public function testSaveExistingOption()
             '',
             false
         );
-        $optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
         $optCollectionMock->expects($this->once())->method('getItemById')
             ->with($optionId)
             ->willReturn($existingOptionMock);
@@ -479,7 +477,6 @@ public function testSaveExistingOptionNoSuchOption()
             '',
             false
         );
-        $optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
         $optCollectionMock->expects($this->once())->method('getItemById')
             ->with($optionId)
             ->willReturn($existingOptionMock);

app/code/Magento/Bundle/etc/webapi.xml

@@ -13,7 +13,7 @@
             <resource ref="Magento_Catalog::products"/>
         </resources>
     </route>
-    <route url="/V1/bundle-products/:sku/links" method="PUT">
+    <route url="/V1/bundle-products/:productSku/links" method="PUT">
         <service class="Magento\Bundle\Api\ProductLinkManagementInterface" method="saveChild"/>
         <resources>
             <resource ref="Magento_Catalog::products"/>

dev/tests/api-functional/testsuite/Magento/Bundle/Api/ProductLinkManagementTest.php

@@ -111,11 +111,11 @@ public function testSaveChild()
      */
     private function saveChild($productSku, $linkedProduct)
     {
-        $resourcePath = self::RESOURCE_PATH . '/:sku/links';
+        $resourcePath = self::RESOURCE_PATH . '/:productSku/links';
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => str_replace(
-                    [':sku'],
+                    [':productSku'],
                     [$productSku],
                     $resourcePath
                 ),
@@ -129,7 +129,7 @@ private function saveChild($productSku, $linkedProduct)
         ];
         return $this->_webApiCall(
             $serviceInfo,
-            ['sku' => $productSku, 'linkedProduct' => $linkedProduct]
+            ['productSku' => $productSku, 'linkedProduct' => $linkedProduct]
         );
     }