Skip to content

Commit 4de44b8

Browse files
committed
Fixed most static tests (not all).
1 parent 566ca89 commit 4de44b8

File tree

5 files changed

+20
-21
lines changed

5 files changed

+20
-21
lines changed

app/code/Magento/CatalogInventory/Model/Indexer/Stock/Action/Full.php

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<?php
22
/**
3-
* @category Magento
4-
* @package Magento_CatalogInventory
53
* Copyright © Magento, Inc. All rights reserved.
64
* See COPYING.txt for license details.
75
*/
@@ -11,24 +9,24 @@
119
namespace Magento\CatalogInventory\Model\Indexer\Stock\Action;
1210

1311
use Magento\Catalog\Api\Data\ProductInterface;
12+
use Magento\Catalog\Model\Product\Type as ProductType;
1413
use Magento\Catalog\Model\ResourceModel\Indexer\ActiveTableSwitcher;
14+
use Magento\CatalogInventory\Model\Indexer\Stock\AbstractAction;
15+
use Magento\CatalogInventory\Model\Indexer\Stock\Processor;
1516
use Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\DefaultStock;
16-
use Magento\Framework\App\ResourceConnection;
17+
use Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StockInterface;
1718
use Magento\CatalogInventory\Model\ResourceModel\Indexer\StockFactory;
18-
use Magento\Catalog\Model\Product\Type as ProductType;
19+
use Magento\Framework\App\DeploymentConfig;
20+
use Magento\Framework\App\ObjectManager;
21+
use Magento\Framework\App\ResourceConnection;
1922
use Magento\Framework\DB\Query\BatchIteratorInterface;
2023
use Magento\Framework\DB\Query\Generator as QueryGenerator;
21-
use Magento\Framework\Indexer\CacheContext;
22-
use Magento\Framework\Event\ManagerInterface as EventManager;
2324
use Magento\Framework\EntityManager\MetadataPool;
24-
use Magento\Framework\Indexer\BatchSizeManagementInterface;
25-
use Magento\Framework\Indexer\BatchProviderInterface;
26-
use Magento\Framework\App\ObjectManager;
25+
use Magento\Framework\Event\ManagerInterface as EventManager;
2726
use Magento\Framework\Exception\LocalizedException;
28-
use Magento\CatalogInventory\Model\Indexer\Stock\AbstractAction;
29-
use Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StockInterface;
30-
use Magento\Framework\App\DeploymentConfig;
31-
use Magento\CatalogInventory\Model\Indexer\Stock\Processor;
27+
use Magento\Framework\Indexer\BatchProviderInterface;
28+
use Magento\Framework\Indexer\BatchSizeManagementInterface;
29+
use Magento\Framework\Indexer\CacheContext;
3230

3331
/**
3432
* Class Full reindex action
@@ -40,7 +38,7 @@ class Full extends AbstractAction
4038
/**
4139
* Action type representation
4240
*/
43-
const ACTION_TYPE = 'full';
41+
public const ACTION_TYPE = 'full';
4442

4543
/**
4644
* @var MetadataPool
@@ -164,7 +162,7 @@ public function execute($ids = null): void
164162
)
165163
);
166164

167-
if (is_null($batchRowCount)) {
165+
if ($batchRowCount === null) {
168166
$batchRowCount = isset($this->batchRowsCount[$indexer->getTypeId()])
169167
? $this->batchRowsCount[$indexer->getTypeId()]
170168
: $this->batchRowsCount['default'];

app/code/Magento/CatalogRule/Model/ResourceModel/Rule.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ public function __construct(
132132
// @phpstan-ignore-next-line - this is a virtual type defined in di.xml
133133
->get(\Magento\CatalogRule\Model\ResourceModel\Rule\AssociatedEntityMap::class)
134134
->getData();
135+
135136
parent::__construct($context, $connectionName);
136137
}
137138

@@ -216,12 +217,8 @@ public function getRulesFromProduct($date, $websiteId, $customerGroupId, $produc
216217
}
217218

218219
/**
219-
* Load an object
220+
* @inheritDoc
220221
*
221-
* @param \Magento\Framework\Model\AbstractModel $object
222-
* @param mixed $value
223-
* @param string $field
224-
* @return $this
225222
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
226223
*/
227224
public function load(\Magento\Framework\Model\AbstractModel $object, $value, $field = null)

app/code/Magento/CatalogRule/Model/ResourceModel/Rule/Collection.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ public function addCustomerGroupFilter($customerGroupId)
159159
*
160160
* @return array
161161
* @deprecated 100.1.0
162+
* @see https://github.com/magento/magento2/commit/d063251cf0ce6717795fdb646a534cc0c2b22c05
162163
*/
163164
private function getAssociatedEntitiesMap()
164165
{

app/code/Magento/Cms/Model/PageRepository.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ public function deleteById($pageId)
285285
*
286286
* @deprecated 102.0.0
287287
* @return CollectionProcessorInterface
288+
* @see https://github.com/magento/magento2/commit/eacac63d35b97961e3304dc007cd6b78519a93d0
288289
*/
289290
private function getCollectionProcessor()
290291
{

app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/PrintAction.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class PrintAction extends \Magento\Backend\App\Action
1616
*
1717
* @see _isAllowed()
1818
*/
19-
const ADMIN_RESOURCE = 'Magento_Sales::sales_creditmemo';
19+
public const ADMIN_RESOURCE = 'Magento_Sales::sales_creditmemo';
2020

2121
/**
2222
* @var \Magento\Framework\App\Response\Http\FileFactory
@@ -52,6 +52,8 @@ public function __construct(
5252
}
5353

5454
/**
55+
* Execute action based on request and return result
56+
*
5557
* @return ResponseInterface|\Magento\Backend\Model\View\Result\Forward
5658
* @throws \Exception
5759
*/

0 commit comments

Comments
 (0)