fix implmentation of isSynchronuos attribute processing

Author: Vasiliev.A

app/code/Magento/WebapiAsync/Code/Generator/Config/RemoteServiceReader/Communication.php

@@ -67,7 +67,8 @@ public function read($scope = null)
                         CommunicationConfig::HANDLER_TYPE   => $serviceClass,
                         CommunicationConfig::HANDLER_METHOD => $serviceMethod,
                     ],
-                ]
+                ],
+                false
             );
             $rewriteTopicParams = [
                 CommunicationConfig::TOPIC_IS_SYNCHRONOUS => false,

lib/internal/Magento/Framework/Communication/Config/Reader/XmlReader/Converter.php

@@ -124,7 +124,7 @@ protected function extractTopics($config)
                 $requestSchema,
                 $responseSchema
             );
-            $isSynchronous = $this->extractTopicIsSynchronous($topicNode) ?? null;
+            $isSynchronous = $this->extractTopicIsSynchronous($topicNode);
             if ($serviceMethod) {
                 $output[$topicName] = $this->reflectionGenerator->generateTopicConfigForServiceMethod(
                     $topicName,
@@ -136,7 +136,7 @@ protected function extractTopics($config)
             } elseif ($requestSchema && $responseSchema) {
                 $output[$topicName] = [
                     Config::TOPIC_NAME => $topicName,
-                    Config::TOPIC_IS_SYNCHRONOUS => $isSynchronous ?? true,
+                    Config::TOPIC_IS_SYNCHRONOUS => $isSynchronous,
                     Config::TOPIC_REQUEST => $requestSchema,
                     Config::TOPIC_REQUEST_TYPE => Config::TOPIC_REQUEST_TYPE_CLASS,
                     Config::TOPIC_RESPONSE => ($isSynchronous) ? $responseSchema: null,
@@ -145,7 +145,7 @@ protected function extractTopics($config)
             } elseif ($requestSchema) {
                 $output[$topicName] = [
                     Config::TOPIC_NAME => $topicName,
-                    Config::TOPIC_IS_SYNCHRONOUS => $isSynchronous ?? false,
+                    Config::TOPIC_IS_SYNCHRONOUS => false,
                     Config::TOPIC_REQUEST => $requestSchema,
                     Config::TOPIC_REQUEST_TYPE => Config::TOPIC_REQUEST_TYPE_CLASS,
                     Config::TOPIC_RESPONSE => null,
@@ -265,17 +265,15 @@ protected function parseServiceMethod($serviceMethod, $topicName)
      * Extract is_synchronous topic value.
      *
      * @param \DOMNode $topicNode
-     * @return boolean|null
+     * @return bool
      */
-    protected function extractTopicIsSynchronous($topicNode)
+    private function extractTopicIsSynchronous($topicNode): bool
     {
         $attributeName = Config::TOPIC_IS_SYNCHRONOUS;
         $topicAttributes = $topicNode->attributes;
         if (!$topicAttributes->getNamedItem($attributeName)) {
-            return null;
+            return true;
         }
-        $value = $topicAttributes->getNamedItem($attributeName)->nodeValue;
-        $isSynchronous = filter_var($value, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
-        return $isSynchronous;
+        return $this->booleanUtils->toBoolean($topicAttributes->getNamedItem($attributeName)->nodeValue);
     }
 }