Skip to content

Commit 4d8af02

Browse files
ENGCOM-7005: Removed redundant method _beforeToHtml #27057
2 parents 56b0353 + 5115af3 commit 4d8af02

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

app/code/Magento/Newsletter/Block/Adminhtml/Subscriber.php

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,18 @@
1111
*/
1212
namespace Magento\Newsletter\Block\Adminhtml;
1313

14+
use Magento\Backend\Block\Template;
15+
use Magento\Backend\Block\Template\Context;
1416
use Magento\Newsletter\Model\ResourceModel\Queue\Collection;
17+
use Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory;
1518

1619
/**
20+
* Newsletter Subscriber block
21+
*
1722
* @api
1823
* @since 100.0.2
1924
*/
20-
class Subscriber extends \Magento\Backend\Block\Template
25+
class Subscriber extends Template
2126
{
2227
/**
2328
* Queue collection
@@ -32,34 +37,24 @@ class Subscriber extends \Magento\Backend\Block\Template
3237
protected $_template = 'Magento_Newsletter::subscriber/list.phtml';
3338

3439
/**
35-
* @var \Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory
40+
* @var CollectionFactory
3641
*/
3742
protected $_collectionFactory;
3843

3944
/**
40-
* @param \Magento\Backend\Block\Template\Context $context
41-
* @param \Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory $collectionFactory
45+
* @param Context $context
46+
* @param CollectionFactory $collectionFactory
4247
* @param array $data
4348
*/
4449
public function __construct(
45-
\Magento\Backend\Block\Template\Context $context,
46-
\Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory $collectionFactory,
50+
Context $context,
51+
CollectionFactory $collectionFactory,
4752
array $data = []
4853
) {
4954
$this->_collectionFactory = $collectionFactory;
5055
parent::__construct($context, $data);
5156
}
5257

53-
/**
54-
* Prepares block to render
55-
*
56-
* @return $this
57-
*/
58-
protected function _beforeToHtml()
59-
{
60-
return parent::_beforeToHtml();
61-
}
62-
6358
/**
6459
* Return queue collection with loaded neversent queues
6560
*
@@ -68,7 +63,7 @@ protected function _beforeToHtml()
6863
public function getQueueCollection()
6964
{
7065
if ($this->_queueCollection === null) {
71-
/** @var $this->_queueCollection \Magento\Newsletter\Model\ResourceModel\Queue\Collection */
66+
/** @var $this->_queueCollection Collection */
7267
$this->_queueCollection = $this
7368
->_collectionFactory
7469
->create()

0 commit comments

Comments
 (0)