MC-23058: Template strict mode is not set for unsaved template previews

nathanjosiah · nathanjosiah · commit 4d888f38b407 · 2019-11-13T15:51:07.000-06:00
diff --git a/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php b/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php
@@ -67,6 +67,7 @@ protected function _toHtml()
             $template->setTemplateType($request->getParam('type'));
             $template->setTemplateText($request->getParam('text'));
             $template->setTemplateStyles($request->getParam('styles'));
+            // Emulate DB-loaded template to invoke strict mode
             $template->setTemplateId(123);
         }
 
diff --git a/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview.php b/app/code/Magento/Newsletter/Block/Adminhtml/Template/Preview.php
@@ -65,6 +65,7 @@ protected function _toHtml()
             $template->setTemplateType($previewData['type']);
             $template->setTemplateText($previewData['text']);
             $template->setTemplateStyles($previewData['styles']);
+            // Emulate DB-loaded template to invoke strict mode
             $template->setTemplateId(123);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,7 @@ protected function _toHtml()`
`67`	`67`	`$template->setTemplateType($request->getParam('type'));`
`68`	`68`	`$template->setTemplateText($request->getParam('text'));`
`69`	`69`	`$template->setTemplateStyles($request->getParam('styles'));`
	`70`	`+ // Emulate DB-loaded template to invoke strict mode`
`70`	`71`	`$template->setTemplateId(123);`
`71`	`72`	`}`
`72`	`73`
Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ protected function _toHtml()`
`65`	`65`	`$template->setTemplateType($previewData['type']);`
`66`	`66`	`$template->setTemplateText($previewData['text']);`
`67`	`67`	`$template->setTemplateStyles($previewData['styles']);`
	`68`	`+ // Emulate DB-loaded template to invoke strict mode`
`68`	`69`	`$template->setTemplateId(123);`
`69`	`70`	`}`
`70`	`71`