MC-5620: --convert-old-scripts mode does not convert indexes and constraints correctly

fascinosum · fascinosum · commit 4d0f3b77f000 · 2019-02-06T14:30:56.000-06:00
diff --git a/lib/internal/Magento/Framework/Setup/SchemaPersistor.php b/lib/internal/Magento/Framework/Setup/SchemaPersistor.php
@@ -233,7 +233,7 @@ private function processIndexes(array $tableData, \SimpleXMLElement $table)
                     $domIndex = reset($domIndex);
                 }
 
-                $attributeNames = array_diff(array_keys($indexData), ['referenceId', 'columns']);
+                $attributeNames = array_diff(array_keys($indexData), ['referenceId', 'columns', 'name']);
                 foreach ($attributeNames as $attributeName) {
                     $this->updateElementAttribute(
                         $domIndex,

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ private function processIndexes(array $tableData, \SimpleXMLElement $table)`
`233`	`233`	`$domIndex = reset($domIndex);`
`234`	`234`	`}`
`235`	`235`
`236`		`- $attributeNames = array_diff(array_keys($indexData), ['referenceId', 'columns']);`
	`236`	`+ $attributeNames = array_diff(array_keys($indexData), ['referenceId', 'columns', 'name']);`
`237`	`237`	`foreach ($attributeNames as $attributeName) {`
`238`	`238`	`$this->updateElementAttribute(`
`239`	`239`	`$domIndex,`