MAGETWO-64544: When logged in customer edits a new shipping address during checkout they are unable to place the order #6488

Author: omiroshnichenko

app/code/Magento/Checkout/view/frontend/web/js/model/shipping-rates-validator.js

@@ -15,6 +15,7 @@ define([
     './postcode-validator',
     'mage/translate',
     'uiRegistry',
+    'Magento_Checkout/js/model/shipping-address/form-popup-state',
     'Magento_Checkout/js/model/quote'
 ], function (
     $,
@@ -24,7 +25,8 @@ define([
     selectShippingAddress,
     postcodeValidator,
     $t,
-    uiRegistry
+    uiRegistry,
+    formPopUpState
 ) {
     'use strict';
 
@@ -127,11 +129,13 @@ define([
                 });
             } else {
                 element.on('value', function () {
-                    clearTimeout(self.validateAddressTimeout);
-                    self.validateAddressTimeout = setTimeout(function () {
-                        self.postcodeValidation();
-                        self.validateFields();
-                    }, delay);
+                    if (!formPopUpState.isVisible()) {
+                        clearTimeout(self.validateAddressTimeout);
+                        self.validateAddressTimeout = setTimeout(function () {
+                            self.postcodeValidation();
+                            self.validateFields();
+                        }, delay);
+                    }
                 });
                 observedElements.push(element);
             }

app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js

@@ -60,15 +60,18 @@ define([
             template: 'Magento_Checkout/shipping',
             shippingFormTemplate: 'Magento_Checkout/shipping-address/form',
             shippingMethodListTemplate: 'Magento_Checkout/shipping-address/shipping-method-list',
-            shippingMethodItemTemplate: 'Magento_Checkout/shipping-address/shipping-method-item'
+            shippingMethodItemTemplate: 'Magento_Checkout/shipping-address/shipping-method-item',
+            saveInAddressBook: 1,
+            links: {
+                saveInAddressBook: '${ $.provider }:shippingAddress.save_in_address_book'
+            }
         },
         visible: ko.observable(!quote.isVirtual()),
         errorValidationMessage: ko.observable(false),
         isCustomerLoggedIn: customer.isLoggedIn,
         isFormPopUpVisible: formPopUpState.isVisible,
         isFormInline: addressList().length === 0,
         isNewAddressAdded: ko.observable(false),
-        saveInAddressBook: 1,
         quoteIsVirtual: quote.isVirtual(),
 
         /**
@@ -126,6 +129,14 @@ define([
             return this;
         },
 
+        /** @inheritdoc */
+        initObservable: function () {
+            this._super()
+                .observe('saveInAddressBook');
+
+            return this;
+        },
+
         /**
          * Load data from server for shipping step
          */
@@ -189,7 +200,7 @@ define([
             if (!this.source.get('params.invalid')) {
                 addressData = this.source.get('shippingAddress');
                 // if user clicked the checkbox, its value is true or false. Need to convert.
-                addressData['save_in_address_book'] = this.saveInAddressBook ? 1 : 0;
+                addressData['save_in_address_book'] = this.saveInAddressBook() ? 1 : 0;
 
                 // New address must be selected as a shipping address
                 newShippingAddress = createShippingAddress(addressData);