Skip to content

Commit 4c40dad

Browse files
committed
Fix the error that is wrong link title of a downloadable product when enabling "Use Default Value"
1 parent a66a2d5 commit 4c40dad

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

app/code/Magento/Downloadable/Model/Link/Builder.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public function build(\Magento\Downloadable\Api\Data\LinkInterface $link)
116116
$link->setLinkFile($linkFileName);
117117
$link->setLinkUrl(null);
118118
}
119-
119+
120120
if (isset($this->data['sample'])) {
121121
$link = $this->buildSample($link, $this->data['sample']);
122122
}
@@ -132,6 +132,10 @@ public function build(\Magento\Downloadable\Api\Data\LinkInterface $link)
132132
if (isset($this->data['is_unlimited']) && $this->data['is_unlimited']) {
133133
$link->setNumberOfDownloads(0);
134134
}
135+
136+
if (isset($this->data['use_default_title']) && $this->data['use_default_title'] == '1') {
137+
$link->setTitle(null);
138+
}
135139
$this->resetData();
136140

137141
return $link;

app/code/Magento/Downloadable/Test/Unit/Model/Link/BuilderTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected function setUp()
6868
$this->linkMock = $this->getMockBuilder(LinkInterface::class)
6969
->disableOriginalConstructor()
7070
->getMockForAbstractClass();
71-
71+
7272
$this->service = $objectManagerHelper->getObject(
7373
Builder::class,
7474
[
@@ -160,6 +160,9 @@ public function testBuild($data, $expectedPrice)
160160
if (isset($data['is_unlimited'])) {
161161
$this->linkMock->expects($this->once())->method('setNumberOfDownloads')->with(0);
162162
}
163+
if (isset($data['use_default_title']) && $data['use_default_title'] == '1') {
164+
$this->linkMock->expects($this->once())->method('getTitle')->with(null);
165+
}
163166
if (isset($data['price'])) {
164167
$this->linkMock->expects($this->once())->method('getPrice')->willReturn($data['price']);
165168
} else {

0 commit comments

Comments
 (0)