Merge remote-tracking branch 'arcticfoxes/MC-13806' into 2.3-qwerty-pr

Author: Joan He

lib/internal/Magento/Framework/Encryption/Crypt.php

@@ -41,13 +41,13 @@ class Crypt
     /**
      * Constructor
      *
-     * @param  string      $key        Secret encryption key.
-     *                                 It's unsafe to store encryption key in memory, so no getter for key exists.
-     * @param  string      $cipher     Cipher algorithm (one of the MCRYPT_ciphername constants)
-     * @param  string      $mode       Mode of cipher algorithm (MCRYPT_MODE_modeabbr constants)
-     * @param  string|bool $initVector Initial vector to fill algorithm blocks.
-     *                                 TRUE generates a random initial vector.
-     *                                 FALSE fills initial vector with zero bytes to not use it.
+     * @param string $key Secret encryption key.
+     *                    It's unsafe to store encryption key in memory, so no getter for key exists.
+     * @param string $cipher Cipher algorithm (one of the MCRYPT_ciphername constants)
+     * @param string $mode Mode of cipher algorithm (MCRYPT_MODE_modeabbr constants)
+     * @param string|bool $initVector Initial vector to fill algorithm blocks.
+     *                                TRUE generates a random initial vector.
+     *                                FALSE fills initial vector with zero bytes to not use it.
      * @throws \Exception
      */
     public function __construct(
@@ -66,7 +66,7 @@ public function __construct(
             $allowedCharacters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
             $initVector = '';
             for ($i = 0; $i < $initVectorSize; $i++) {
-                $initVector .= $allowedCharacters[rand(0, strlen($allowedCharacters) - 1)];
+                $initVector .= $allowedCharacters[random_int(0, strlen($allowedCharacters) - 1)];
             }
             // @codingStandardsIgnoreStart
             @mcrypt_generic_deinit($handle);