MAGETWO-52891: [FT] CreateSimpleProductEntityTest failed to recognize a comma and a dot in the product price

 - added correct price and weight formats on backend product form

Author: Robert He

app/code/Magento/Catalog/Test/Unit/Ui/DataProvider/Product/Form/Modifier/EavTest.php

@@ -10,6 +10,7 @@
 use Magento\Eav\Model\Config;
 use Magento\Framework\App\RequestInterface;
 use Magento\Store\Model\StoreManagerInterface;
+use Magento\Store\Api\Data\StoreInterface;
 use Magento\Ui\DataProvider\EavValidationRules;
 use Magento\Eav\Model\ResourceModel\Entity\Attribute\Group\Collection as GroupCollection;
 use Magento\Eav\Model\ResourceModel\Entity\Attribute\Group\CollectionFactory as GroupCollectionFactory;
@@ -28,6 +29,8 @@
 use Magento\Catalog\Api\Data\ProductAttributeInterface;
 use Magento\Eav\Api\Data\AttributeGroupInterface;
 use Magento\Catalog\Model\ResourceModel\Eav\Attribute;
+use Magento\Framework\Currency;
+use Magento\Framework\Locale\Currency as CurrencyLocale;
 
 /**
  * Class EavTest
@@ -138,6 +141,21 @@ class EavTest extends AbstractModifierTest
      */
     private $eavAttributeMock;
 
+    /**
+     * @var StoreInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    protected $storeMock;
+
+    /**
+     * @var Currency|\PHPUnit_Framework_MockObject_MockObject
+     */
+    protected $currencyMock;
+
+    /**
+     * @var CurrencyLocale|\PHPUnit_Framework_MockObject_MockObject
+     */
+    protected $currencyLocaleMock;
+
     protected function setUp()
     {
         parent::setUp();
@@ -236,6 +254,17 @@ protected function setUp()
             ->willReturn([
                 $this->attributeMock,
             ]);
+        $this->storeMock = $this->getMockBuilder(StoreInterface::class)
+            ->setMethods(['load', 'getId', 'getConfig', 'getBaseCurrencyCode'])
+            ->getMockForAbstractClass();
+        $this->currencyMock = $this->getMockBuilder(Currency::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['toCurrency'])
+            ->getMock();
+        $this->currencyLocaleMock = $this->getMockBuilder(CurrencyLocale::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getCurrency'])
+            ->getMock();
     }
 
     /**
@@ -255,7 +284,8 @@ protected function createModel()
             'searchCriteriaBuilder' => $this->searchCriteriaBuilderMock,
             'attributeGroupRepository' => $this->attributeGroupRepositoryMock,
             'sortOrderBuilder' => $this->sortOrderBuilderMock,
-            'attributeRepository' => $this->attributeRepositoryMock
+            'attributeRepository' => $this->attributeRepositoryMock,
+            'localeCurrency' => $this->currencyLocaleMock,
         ]);
     }
 
@@ -336,6 +366,19 @@ public function testModifyData()
             ->method('getItems')
             ->willReturn([$this->eavAttributeMock]);
 
+        $this->storeMock->expects(($this->once()))
+            ->method('getBaseCurrencyCode')
+            ->willReturn('en_US');
+        $this->storeManagerMock->expects($this->once())
+            ->method('getStore')
+            ->willReturn($this->storeMock);
+        $this->currencyMock->expects($this->once())
+            ->method('toCurrency')
+            ->willReturn('19.99');
+        $this->currencyLocaleMock->expects($this->once())
+            ->method('getCurrency')
+            ->willReturn($this->currencyMock);
+
         $this->assertEquals($sourceData, $this->getModel()->modifyData([]));
     }
 }

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/CustomOptions.php

@@ -22,6 +22,7 @@
 use Magento\Ui\Component\Form\Element\ActionDelete;
 use Magento\Ui\Component\Form\Element\DataType\Text;
 use Magento\Ui\Component\Form\Element\DataType\Number;
+use Magento\Framework\Locale\CurrencyInterface;
 
 /**
  * Data provider for "Customizable Options" panel
@@ -112,6 +113,11 @@ class CustomOptions extends AbstractModifier
      */
     protected $urlBuilder;
 
+    /**
+     * @var CurrencyInterface
+     */
+    protected $localeCurrency;
+
     /**
      * @var ArrayManager
      */
@@ -128,6 +134,7 @@ class CustomOptions extends AbstractModifier
      * @param ConfigInterface $productOptionsConfig
      * @param ProductOptionsPrice $productOptionsPrice
      * @param UrlInterface $urlBuilder
+     * @param CurrencyInterface $localeCurrency
      * @param ArrayManager $arrayManager
      */
     public function __construct(
@@ -136,13 +143,15 @@ public function __construct(
         ConfigInterface $productOptionsConfig,
         ProductOptionsPrice $productOptionsPrice,
         UrlInterface $urlBuilder,
+        CurrencyInterface $localeCurrency,
         ArrayManager $arrayManager
     ) {
         $this->locator = $locator;
         $this->storeManager = $storeManager;
         $this->productOptionsConfig = $productOptionsConfig;
         $this->productOptionsPrice = $productOptionsPrice;
         $this->urlBuilder = $urlBuilder;
+        $this->localeCurrency = $localeCurrency;
         $this->arrayManager = $arrayManager;
     }
 
@@ -1069,4 +1078,23 @@ protected function getCurrencySymbol()
     {
         return $this->storeManager->getStore()->getBaseCurrency()->getCurrencySymbol();
     }
+
+    /**
+     * Format price according to the locale of the currency
+     *
+     * @param mixed $value
+     * @return string
+     */
+    protected function formatPrice($value)
+    {
+        if (!is_numeric($value)) {
+            return null;
+        }
+
+        $store = $this->storeManager->getStore();
+        $currency = $this->localeCurrency->getCurrency($store->getBaseCurrencyCode());
+        $value = $currency->toCurrency($value, ['display' => \Magento\Framework\Currency::NO_SYMBOL]);
+
+        return $value;
+    }
 }

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php

@@ -30,6 +30,7 @@
 use Magento\Ui\DataProvider\Mapper\MetaProperties as MetaPropertiesMapper;
 use Magento\Ui\Component\Form\Element\Wysiwyg as WysiwygElement;
 use Magento\Catalog\Model\Attribute\ScopeOverriddenValue;
+use Magento\Framework\Locale\CurrencyInterface;
 
 /**
  * Class Eav
@@ -161,6 +162,11 @@ class Eav extends AbstractModifier
      */
     private $prevSetAttributes;
 
+    /**
+     * @var CurrencyInterface
+     */
+    protected $localeCurrency;
+
     /**
      * @param LocatorInterface $locator
      * @param CatalogEavValidationRules $catalogEavValidationRules
@@ -179,6 +185,7 @@ class Eav extends AbstractModifier
      * @param ArrayManager $arrayManager
      * @param ScopeOverriddenValue $scopeOverriddenValue
      * @param DataPersistorInterface $dataPersistor
+     * @param CurrencyInterface $localeCurrency
      * @param array $attributesToDisable
      * @param array $attributesToEliminate
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
@@ -201,6 +208,7 @@ public function __construct(
         ArrayManager $arrayManager,
         ScopeOverriddenValue $scopeOverriddenValue,
         DataPersistorInterface $dataPersistor,
+        CurrencyInterface $localeCurrency,
         $attributesToDisable = [],
         $attributesToEliminate = []
     ) {
@@ -221,6 +229,7 @@ public function __construct(
         $this->arrayManager = $arrayManager;
         $this->scopeOverriddenValue = $scopeOverriddenValue;
         $this->dataPersistor = $dataPersistor;
+        $this->localeCurrency = $localeCurrency;
         $this->attributesToDisable = $attributesToDisable;
         $this->attributesToEliminate = $attributesToEliminate;
     }
@@ -867,4 +876,23 @@ private function calculateGroupCode(AttributeGroupInterface $group)
 
         return $attributeGroupCode;
     }
+
+    /**
+     * Format price according to the locale of the currency
+     *
+     * @param mixed $value
+     * @return string
+     */
+    protected function formatPrice($value)
+    {
+        if (!is_numeric($value)) {
+            return null;
+        }
+
+        $store = $this->storeManager->getStore();
+        $currency = $this->localeCurrency->getCurrency($store->getBaseCurrencyCode());
+        $value = $currency->toCurrency($value, ['display' => \Magento\Framework\Currency::NO_SYMBOL]);
+
+        return $value;
+    }
 }

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/General.php

@@ -9,6 +9,8 @@
 use Magento\Catalog\Model\Locator\LocatorInterface;
 use Magento\Ui\Component\Form;
 use Magento\Framework\Stdlib\ArrayManager;
+use Magento\Store\Model\StoreManagerInterface;
+use Magento\Framework\Locale\CurrencyInterface;
 
 /**
  * Data provider for main panel of product page
@@ -24,17 +26,33 @@ class General extends AbstractModifier
      * @var ArrayManager
      */
     protected $arrayManager;
+    
+    /**
+     * @var StoreManagerInterface
+     */
+    protected $storeManager;
+
+    /**
+     * @var CurrencyInterface
+     */
+    protected $localeCurrency;
 
     /**
      * @param LocatorInterface $locator
      * @param ArrayManager $arrayManager
+     * @param StoreManagerInterface $storeManager
+     * @param CurrencyInterface $localeCurrency
      */
     public function __construct(
         LocatorInterface $locator,
-        ArrayManager $arrayManager
+        ArrayManager $arrayManager,
+        StoreManagerInterface $storeManager,
+        CurrencyInterface $localeCurrency
     ) {
         $this->locator = $locator;
         $this->arrayManager = $arrayManager;
+        $this->storeManager = $storeManager;
+        $this->localeCurrency = $localeCurrency;
     }
 
     /**
@@ -70,7 +88,7 @@ protected function customizeWeightFormat(array $data)
             $data = $this->arrayManager->replace(
                 $path,
                 $data,
-                $this->formatWeight($this->arrayManager->get($path, $data))
+                $this->formatNumber($this->arrayManager->get($path, $data))
             );
         }
 
@@ -93,7 +111,7 @@ protected function customizeAdvancedPriceFormat(array $data)
                 $value[ProductAttributeInterface::CODE_TIER_PRICE_FIELD_PRICE] =
                     $this->formatPrice($value[ProductAttributeInterface::CODE_TIER_PRICE_FIELD_PRICE]);
                 $value[ProductAttributeInterface::CODE_TIER_PRICE_FIELD_PRICE_QTY] =
-                    (int)$value[ProductAttributeInterface::CODE_TIER_PRICE_FIELD_PRICE_QTY];
+                    $this->formatNumber((int)$value[ProductAttributeInterface::CODE_TIER_PRICE_FIELD_PRICE_QTY]);
             }
         }
 
@@ -350,4 +368,45 @@ protected function customizeNameListeners(array $meta)
             ]
         );
     }
+
+    /**
+     * Format price according to the locale of the currency
+     *
+     * @param mixed $value
+     * @return string
+     */
+    protected function formatPrice($value)
+    {
+        if (!is_numeric($value)) {
+            return null;
+        }
+
+        $store = $this->storeManager->getStore();
+        $currency = $this->localeCurrency->getCurrency($store->getBaseCurrencyCode());
+        $value = $currency->toCurrency($value, ['display' => \Magento\Framework\Currency::NO_SYMBOL]);
+
+        return $value;
+    }
+
+    /**
+     * Format number according to the locale of the currency and precision of input
+     *
+     * @param mixed $value
+     * @return string
+     */
+    protected function formatNumber($value)
+    {
+        if (!is_numeric($value)) {
+            return null;
+        }
+
+        $value = (float)$value;
+        $precision = strlen(substr(strrchr($value, "."), 1));
+        $store = $this->storeManager->getStore();
+        $currency = $this->localeCurrency->getCurrency($store->getBaseCurrencyCode());
+        $value = $currency->toCurrency($value, ['display' => \Magento\Framework\Currency::NO_SYMBOL,
+                                                'precision' => $precision]);
+
+        return $value;
+    }
 }