MAGETWO-67871: Requesting autogenerated classes that are not in constructor cause fatal errors in production mode

- add factory generation for setup application

Author: Igor Melnikov

setup/src/Magento/Setup/Console/Command/DiCompileCommand.php

@@ -132,17 +132,21 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $modulePaths = $this->componentRegistrar->getPaths(ComponentRegistrar::MODULE);
         $libraryPaths = $this->componentRegistrar->getPaths(ComponentRegistrar::LIBRARY);
+        $setupPath = $this->directoryList->getPath(DirectoryList::SETUP);
         $generationPath = $this->directoryList->getPath(DirectoryList::GENERATED_CODE);
 
         $this->objectManager->get(\Magento\Framework\App\Cache::class)->clean();
         $compiledPathsList = [
             'application' => $modulePaths,
             'library' => $libraryPaths,
+            'setup' => $setupPath,
             'generated_helpers' => $generationPath
         ];
+
         $this->excludedPathsList = [
             'application' => $this->getExcludedModulePaths($modulePaths),
             'framework' => $this->getExcludedLibraryPaths($libraryPaths),
+            'setup' => $this->getExcludedSetupPaths($setupPath),
         ];
         $this->configureObjectManager($output);
 
@@ -247,6 +251,19 @@ private function getExcludedLibraryPaths(array $libraryPaths)
         return $excludedLibraryPaths;
     }
 
+    /**
+     * Get excluded setup application paths
+     *
+     * @param string $setupPath
+     * @return string[]
+     */
+    private function getExcludedSetupPaths($setupPath)
+    {
+        return [
+            '#^(?:' . $setupPath . ')(/[\\w]+)*/Test#'
+        ];
+    }
+
     /**
      * Delete directories by their code from "var" directory
      *
@@ -331,6 +348,7 @@ private function getOperationsConfiguration(
                 'paths' => [
                     $compiledPathsList['application'],
                     $compiledPathsList['library'],
+                    $compiledPathsList['setup'],
                     $compiledPathsList['generated_helpers'],
                 ],
                 'filePatterns' => ['php' => '/\.php$/'],