Skip to content

Commit 499a06f

Browse files
committed
MC-22569: Storefront: Check special/tier/group/rule/option price for product
1 parent 952d3ab commit 499a06f

7 files changed

+29
-13
lines changed

dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ListProduct/CheckProductPriceTest.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class CheckProductPriceTest extends TestCase
5050
protected function setUp()
5151
{
5252
$this->objectManager = Bootstrap::getObjectManager();
53-
$this->pageFactory = $this->objectManager->create(PageFactory::class);
54-
$this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
53+
$this->pageFactory = $this->objectManager->get(PageFactory::class);
54+
$this->productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
5555
$this->customerSession = $this->objectManager->create(Session::class);
5656
parent::setUp();
5757
}
@@ -140,10 +140,7 @@ public function testCheckFixedTierPriceForLoggedUser(): void
140140
{
141141
$priceHtml = $this->getProductPriceHtml('simple_product');
142142
$this->assertFinalPrice($priceHtml, 50.00);
143-
$this->assertNotRegExp(
144-
'/\$10/',
145-
$priceHtml
146-
);
143+
$this->assertNotRegExp('/\$10/', $priceHtml);
147144
$this->customerSession->setCustomerId(1);
148145
try {
149146
$priceHtml = $this->getProductPriceHtml('simple_product');
@@ -299,7 +296,7 @@ private function getProductPriceHtml(string $sku): string
299296
*/
300297
private function getListProductBlock(): ListProduct
301298
{
302-
$page = $this->pageFactory->create(PageFactory::class);
299+
$page = $this->pageFactory->create();
303300
$page->addHandle([
304301
'default',
305302
'catalog_category_view',

dev/tests/integration/testsuite/Magento/Catalog/_files/product_simple_with_fixed_tier_price_for_logged_user.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
use Magento\Catalog\Api\Data\ProductTierPriceExtensionFactory;
99
use Magento\Catalog\Api\Data\ProductTierPriceInterfaceFactory;
10-
use Magento\Customer\Model\Group;
1110
use Magento\Store\Api\WebsiteRepositoryInterface;
1211

1312
require __DIR__ . '/product_simple_without_price_configurations.php';

dev/tests/integration/testsuite/Magento/Catalog/_files/product_simple_without_price_configurations.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,15 @@
1212
use Magento\Catalog\Model\Product\Attribute\Source\Status;
1313
use Magento\Catalog\Model\Product\Type;
1414
use Magento\Catalog\Model\Product\Visibility;
15+
use Magento\Store\Model\WebsiteRepository;
1516
use Magento\TestFramework\Helper\Bootstrap;
1617
use Magento\TestFramework\ObjectManager;
1718

1819
/** @var ObjectManager $objectManager */
1920
$objectManager = Bootstrap::getObjectManager();
21+
/** @var WebsiteRepository $websiteRepository */
22+
$websiteRepository = $objectManager->get(WebsiteRepository::class);
23+
$baseWebsite = $websiteRepository->get('base');
2024
/** @var ProductInterface $productModel */
2125
$productModel = $objectManager->get(ProductInterface::class);
2226
/** @var ProductInterfaceFactory $productFactory */
@@ -28,7 +32,7 @@
2832
'data' => [
2933
'type_id' => Type::TYPE_SIMPLE,
3034
'attribute_set_id' => $productModel->getDefaultAttributeSetid(),
31-
'website_ids' => [1],
35+
'website_ids' => [$baseWebsite->getId()],
3236
'name' => 'Simple product',
3337
'sku' => 'simple_product',
3438
'price' => 50,

dev/tests/integration/testsuite/Magento/CatalogRule/_files/rule_adjust_final_price_to_discount_value_not_logged_user.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@
1010
use Magento\CatalogRule\Api\Data\RuleInterfaceFactory;
1111
use Magento\CatalogRule\Model\Indexer\IndexBuilder;
1212
use Magento\Customer\Model\Group;
13+
use Magento\Store\Model\WebsiteRepository;
1314
use Magento\TestFramework\Helper\Bootstrap;
1415

1516
$objectManager = Bootstrap::getObjectManager();
17+
/** @var WebsiteRepository $websiteRepository */
18+
$websiteRepository = $objectManager->get(WebsiteRepository::class);
19+
$baseWebsite = $websiteRepository->get('base');
1620
/** @var IndexBuilder $indexBuilder */
1721
$indexBuilder = $objectManager->get(IndexBuilder::class);
1822
/** @var CatalogRuleRepositoryInterface $catalogRuleRepository */
@@ -26,7 +30,7 @@
2630
RuleInterface::NAME => 'Test Catalog Rule for not logged user',
2731
'customer_group_ids' => Group::NOT_LOGGED_IN_ID,
2832
RuleInterface::DISCOUNT_AMOUNT => 10,
29-
'website_ids' => [1],
33+
'website_ids' => [$baseWebsite->getId()],
3034
RuleInterface::SIMPLE_ACTION => 'to_fixed',
3135
RuleInterface::STOP_RULES_PROCESSING => false,
3236
RuleInterface::SORT_ORDER => 0,

dev/tests/integration/testsuite/Magento/CatalogRule/_files/rule_adjust_final_price_to_this_percentage_not_logged_user.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@
1010
use Magento\CatalogRule\Api\Data\RuleInterfaceFactory;
1111
use Magento\CatalogRule\Model\Indexer\IndexBuilder;
1212
use Magento\Customer\Model\Group;
13+
use Magento\Store\Model\WebsiteRepository;
1314
use Magento\TestFramework\Helper\Bootstrap;
1415

1516
$objectManager = Bootstrap::getObjectManager();
17+
/** @var WebsiteRepository $websiteRepository */
18+
$websiteRepository = $objectManager->get(WebsiteRepository::class);
19+
$baseWebsite = $websiteRepository->get('base');
1620
/** @var IndexBuilder $indexBuilder */
1721
$indexBuilder = $objectManager->get(IndexBuilder::class);
1822
/** @var CatalogRuleRepositoryInterface $catalogRuleRepository */
@@ -26,7 +30,7 @@
2630
RuleInterface::NAME => 'Test Catalog Rule for not logged user',
2731
'customer_group_ids' => Group::NOT_LOGGED_IN_ID,
2832
RuleInterface::DISCOUNT_AMOUNT => 10,
29-
'website_ids' => [1],
33+
'website_ids' => [$baseWebsite->getId()],
3034
RuleInterface::SIMPLE_ACTION => 'to_percent',
3135
RuleInterface::STOP_RULES_PROCESSING => false,
3236
RuleInterface::SORT_ORDER => 0,

dev/tests/integration/testsuite/Magento/CatalogRule/_files/rule_apply_as_fixed_amount_not_logged_user.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@
1010
use Magento\CatalogRule\Api\Data\RuleInterfaceFactory;
1111
use Magento\CatalogRule\Model\Indexer\IndexBuilder;
1212
use Magento\Customer\Model\Group;
13+
use Magento\Store\Model\WebsiteRepository;
1314
use Magento\TestFramework\Helper\Bootstrap;
1415

1516
$objectManager = Bootstrap::getObjectManager();
17+
/** @var WebsiteRepository $websiteRepository */
18+
$websiteRepository = $objectManager->get(WebsiteRepository::class);
19+
$baseWebsite = $websiteRepository->get('base');
1620
/** @var IndexBuilder $indexBuilder */
1721
$indexBuilder = $objectManager->get(IndexBuilder::class);
1822
/** @var CatalogRuleRepositoryInterface $catalogRuleRepository */
@@ -26,7 +30,7 @@
2630
RuleInterface::NAME => 'Test Catalog Rule for not logged user',
2731
'customer_group_ids' => Group::NOT_LOGGED_IN_ID,
2832
RuleInterface::DISCOUNT_AMOUNT => 10,
29-
'website_ids' => [1],
33+
'website_ids' => [$baseWebsite->getId()],
3034
RuleInterface::SIMPLE_ACTION => 'by_fixed',
3135
RuleInterface::STOP_RULES_PROCESSING => false,
3236
RuleInterface::SORT_ORDER => 0,

dev/tests/integration/testsuite/Magento/CatalogRule/_files/rule_apply_as_percentage_of_original_not_logged_user.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@
1010
use Magento\CatalogRule\Api\Data\RuleInterfaceFactory;
1111
use Magento\CatalogRule\Model\Indexer\IndexBuilder;
1212
use Magento\Customer\Model\Group;
13+
use Magento\Store\Model\WebsiteRepository;
1314
use Magento\TestFramework\Helper\Bootstrap;
1415

1516
$objectManager = Bootstrap::getObjectManager();
17+
/** @var WebsiteRepository $websiteRepository */
18+
$websiteRepository = $objectManager->get(WebsiteRepository::class);
19+
$baseWebsite = $websiteRepository->get('base');
1620
/** @var IndexBuilder $indexBuilder */
1721
$indexBuilder = $objectManager->get(IndexBuilder::class);
1822
/** @var CatalogRuleRepositoryInterface $catalogRuleRepository */
@@ -26,7 +30,7 @@
2630
RuleInterface::NAME => 'Test Catalog Rule for not logged user',
2731
'customer_group_ids' => Group::NOT_LOGGED_IN_ID,
2832
RuleInterface::DISCOUNT_AMOUNT => 10,
29-
'website_ids' => [1],
33+
'website_ids' => [$baseWebsite->getId()],
3034
RuleInterface::SIMPLE_ACTION => 'by_percent',
3135
RuleInterface::STOP_RULES_PROCESSING => false,
3236
RuleInterface::SORT_ORDER => 0,

0 commit comments

Comments
 (0)