Skip to content

Commit 490e465

Browse files
committed
Merge remote-tracking branch 'origin/MAGETWO-45887' into BUGS
2 parents 5f9a631 + 1bc4f34 commit 490e465

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/internal/Magento/Framework/View/Page/Config/Renderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function renderHeadContent()
106106
*/
107107
public function renderTitle()
108108
{
109-
return '<title>' . $this->pageConfig->getTitle()->get() . '</title>' . "\n";
109+
return '<title>' . $this->escaper->escapeHtml($this->pageConfig->getTitle()->get()) . '</title>' . "\n";
110110
}
111111

112112
/**

lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,15 @@ public function testRenderTitle()
179179

180180
$this->pageConfigMock->expects($this->any())
181181
->method('getTitle')
182-
->will($this->returnValue($this->titleMock));
182+
->willReturn($this->titleMock);
183183

184184
$this->titleMock->expects($this->once())
185185
->method('get')
186-
->will($this->returnValue($title));
186+
->willReturn($title);
187+
188+
$this->escaperMock->expects($this->once())
189+
->method('escapeHtml')
190+
->willReturnArgument(0);
187191

188192
$this->assertEquals($expected, $this->renderer->renderTitle());
189193
}

0 commit comments

Comments
 (0)