AC-10042::/V1/transactions REST API returns error when parent_txn_id = txn_id

Author: AshishKumarPundeer

app/code/Magento/Sales/Model/ResourceModel/Order/Payment/Transaction.php

@@ -139,16 +139,23 @@ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $transacti
         $orderId = $transaction->getData('order_id');
         $paymentId = $transaction->getData('payment_id');
         $idFieldName = $this->getIdFieldName();
-
+        $txnType = $transaction->getData('txn_type');
         if ($parentTxnId) {
             if (!$txnId || !$orderId || !$paymentId) {
                 throw new \Magento\Framework\Exception\LocalizedException(
                     __('We don\'t have enough information to save the parent transaction ID.')
                 );
             }
             $parentId = (int)$this->_lookupByTxnId($orderId, $paymentId, $parentTxnId, $idFieldName);
-            if ($parentId) {
+            if ($parentId && $txnType == 'authorization') {
                 $transaction->setData('parent_id', $parentId);
+                $transaction->setData('txn_type',\Magento\Sales\Model\Order\Payment\Transaction::TYPE_CAPTURE);
+            }
+        } else {
+            $result = $this->getParentId($orderId);
+            if ($result) {
+                $transaction->setData('parent_id', $result[0]['transaction_id']);
+                $transaction->setData('parent_txn_id', $result[0]['parent_txn_id']);
             }
         }
 
@@ -211,4 +218,23 @@ private function _getLoadByUniqueKeySelect($orderId, $paymentId, $txnId, $column
             $txnId
         );
     }
+
+    /**
+     * Retrieve transaction by the unique key of order_id
+     *
+     * @param int $orderId
+     * @return array
+     */
+    protected function getParentId(int $orderId): array
+    {
+        $connection = $this->getConnection();
+        $select = $connection->select()->from(
+            $this->getMainTable(),
+            ['transaction_id','parent_txn_id']
+        )->where(
+            'order_id = ?',
+            $orderId
+        )->order('transaction_id','ASC')->limit(1);
+        return $connection->fetchAll($select);
+    }
 }

dev/tests/integration/testsuite/Magento/Sales/_files/transactions_detailed.php

@@ -25,6 +25,6 @@
 $payment->setIsTransactionClosed(false);
 $payment->setTransactionAdditionalInfo('capture_key', 'data');
 $payment->setParentTransactionId('trx_auth');
-$payment->addTransaction(\Magento\Sales\Model\Order\Payment\Transaction::TYPE_CAPTURE);
+$payment->addTransaction(\Magento\Sales\Model\Order\Payment\Transaction::TYPE_AUTH);
 
 $order->save();

dev/tests/integration/testsuite/Magento/Sales/_files/transactions_list.php

@@ -54,7 +54,7 @@
 /** @var array $transactionData */
 foreach ($transactions as $transactionData) {
     $payment->addData($transactionData);
-    $payment->addTransaction(\Magento\Sales\Model\Order\Payment\Transaction::TYPE_CAPTURE);
+    $payment->addTransaction(\Magento\Sales\Model\Order\Payment\Transaction::TYPE_AUTH);
 }
 
 $order->save();