MAGETWO-53008: [Github] Format of responses doesn't match Swagger

Hayder Sharhan · Hayder Sharhan · commit 48373c3eea2e · 2016-05-26T13:41:17.000-05:00
- Fixed formatting.
diff --git a/app/code/Magento/Webapi/Model/Rest/Swagger/Generator.php b/app/code/Magento/Webapi/Model/Rest/Swagger/Generator.php
@@ -19,6 +19,7 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Phrase;
 use Magento\Framework\App\ProductMetadataInterface;
+use \Magento\Framework\Api\SimpleDataObjectConverter;
 
 /**
  * REST Swagger schema generator.
@@ -560,8 +561,7 @@ private function snakeCaseDefinitions($definitions)
             if (!empty($vals['required'])) {
                 $snakeCaseRequired = [];
                 foreach ($vals['required'] as $requiredProperty) {
-                    $snakeCaseRequired[]
-                        = \Magento\Framework\Api\SimpleDataObjectConverter::camelCaseToSnakeCase($requiredProperty);
+                    $snakeCaseRequired[] = SimpleDataObjectConverter::camelCaseToSnakeCase($requiredProperty);
                 }
                 $definitions[$name]['required'] = $snakeCaseRequired;
             }
@@ -578,7 +578,7 @@ private function snakeCaseDefinitions($definitions)
     private function convertArrayToSnakeCase($properties)
     {
         foreach ($properties as $name => $value) {
-            $snakeCaseName = \Magento\Framework\Api\SimpleDataObjectConverter::camelCaseToSnakeCase($name);
+            $snakeCaseName = SimpleDataObjectConverter::camelCaseToSnakeCase($name);
             if (is_array($value)) {
                 $value = $this->convertArrayToSnakeCase($value);
             }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`use Magento\Framework\Exception\NoSuchEntityException;`
`20`	`20`	`use Magento\Framework\Phrase;`
`21`	`21`	`use Magento\Framework\App\ProductMetadataInterface;`
	`22`	`+use \Magento\Framework\Api\SimpleDataObjectConverter;`
`22`	`23`
`23`	`24`	`/**`
`24`	`25`	`* REST Swagger schema generator.`
`@@ -560,8 +561,7 @@ private function snakeCaseDefinitions($definitions)`
`560`	`561`	`if (!empty($vals['required'])) {`
`561`	`562`	`$snakeCaseRequired = [];`
`562`	`563`	`foreach ($vals['required'] as $requiredProperty) {`
`563`		`- $snakeCaseRequired[]`
`564`		`- = \Magento\Framework\Api\SimpleDataObjectConverter::camelCaseToSnakeCase($requiredProperty);`
	`564`	`+ $snakeCaseRequired[] = SimpleDataObjectConverter::camelCaseToSnakeCase($requiredProperty);`
`565`	`565`	`}`
`566`	`566`	`$definitions[$name]['required'] = $snakeCaseRequired;`
`567`	`567`	`}`
`@@ -578,7 +578,7 @@ private function snakeCaseDefinitions($definitions)`
`578`	`578`	`private function convertArrayToSnakeCase($properties)`
`579`	`579`	`{`
`580`	`580`	`foreach ($properties as $name => $value) {`
`581`		`- $snakeCaseName = \Magento\Framework\Api\SimpleDataObjectConverter::camelCaseToSnakeCase($name);`
	`581`	`+ $snakeCaseName = SimpleDataObjectConverter::camelCaseToSnakeCase($name);`
`582`	`582`	`if (is_array($value)) {`
`583`	`583`	`$value = $this->convertArrayToSnakeCase($value);`
`584`	`584`	`}`