MAGETWO-58997: Copy past detector fails in Vault module

 - Fixed failed tests

Author: YevSent

app/code/Magento/Vault/Api/PaymentMethodListInterface.php

@@ -16,7 +16,7 @@ interface PaymentMethodListInterface
 {
     /**
      * Get list of available vault payments
-     * @param $storeId
+     * @param int $storeId
      * @return VaultPaymentInterface[]
      */
     public function getList($storeId);

app/code/Magento/Vault/Model/PaymentMethodList.php

@@ -73,6 +73,6 @@ function (MethodInterface $methodInstance) {
                 return $methodInstance instanceof VaultPaymentInterface;
             }
         );
-        return $availableMethods;
+        return array_values($availableMethods);
     }
 }

dev/tests/integration/testsuite/Magento/Braintree/Model/PaymentMethodListTest.php

@@ -37,7 +37,6 @@ protected function setUp()
     }
 
     /**
-     * @covers \Magento\Vault\Api\PaymentMethodListInterface::getList
      * @magentoDataFixture Magento/Braintree/_files/payments.php
      */
     public function testGetList()
@@ -58,7 +57,6 @@ public function testGetList()
     }
 
     /**
-     * @covers \Magento\Vault\Api\PaymentMethodListInterface::getActiveList
      * @magentoDataFixture Magento/Braintree/_files/payments.php
      */
     public function testGetActiveList()
@@ -67,6 +65,7 @@ public function testGetActiveList()
 
         static::assertNotEmpty($vaultPayments);
         static::assertCount(1, $vaultPayments);
-        static::assertEquals(PayPalConfigProvider::PAYPAL_VAULT_CODE, $vaultPayments[0]->getCode());
+        $payment = array_pop($vaultPayments);
+        static::assertEquals(PayPalConfigProvider::PAYPAL_VAULT_CODE, $payment->getCode());
     }
 }