MAGETWO-32894: Refactor Catalog and related module to use mutable data object interface

    - Improve performance by caching config data

Author: Yu Tang

dev/tests/unit/testsuite/Magento/Framework/Api/Config/MetadataConfigTest.php

@@ -0,0 +1,72 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Framework\Api\Config;
+
+class MetadataConfigTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var \Magento\Framework\Api\Config\MetadataConfig
+     */
+    protected $metadataConfig;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Api\Config\Reader
+     */
+    protected $serviceConfigReaderMock;
+
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\Api\AttributeMetadataBuilderInterface
+     */
+    protected $attributeMetadataBuilderMock;
+
+    /**
+     * Prepare parameters
+     */
+    public function setUp()
+    {
+        $this->serviceConfigReaderMock = $this->getMockBuilder('\Magento\Framework\Api\Config\Reader')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->attributeMetadataBuilderMock = $this->getMockBuilder(
+            '\Magento\Framework\Api\AttributeMetadataBuilderInterface'
+        )->disableOriginalConstructor()->getMock();
+
+        $this->metadataConfig = new \Magento\Framework\Api\Config\MetadataConfig(
+            $this->serviceConfigReaderMock,
+            $this->attributeMetadataBuilderMock
+        );
+    }
+
+    /**
+     * Test caching
+     */
+    public function testCaching()
+    {
+        $dataObjectClassName = '\Magento\Customer\Model\Data\Address';
+        $attributeCode = 'street';
+        $allAttributes = [
+            $dataObjectClassName => [
+                $attributeCode => 'value',
+            ]
+        ];
+        $this->serviceConfigReaderMock->expects($this->once())
+            ->method('read')
+            ->willReturn($allAttributes);
+
+        $attributeMock = $this->getMock('\Magento\Framework\Api\MetadataObjectInterface');
+        $this->attributeMetadataBuilderMock->expects($this->exactly(2))
+            ->method('setAttributeCode')
+            ->with($attributeCode);
+        $this->attributeMetadataBuilderMock->expects($this->exactly(2))
+            ->method('create')
+            ->willReturn($attributeMock);
+
+        $attributes = $this->metadataConfig->getCustomAttributesMetadata($dataObjectClassName);
+        $this->assertEquals($attributeMock, $attributes[$attributeCode]);
+        $attributes = $this->metadataConfig->getCustomAttributesMetadata($dataObjectClassName);
+        $this->assertEquals($attributeMock, $attributes[$attributeCode]);
+    }
+}

lib/internal/Magento/Framework/Api/Config/MetadataConfig.php

@@ -25,6 +25,11 @@ class MetadataConfig implements MetadataServiceInterface
      */
     private $attributeMetadataBuilder;
 
+    /**
+     * @var array
+     */
+    private $allAttributes = [];
+
     /**
      * Initialize dependencies.
      *
@@ -68,11 +73,13 @@ public function getCustomAttributesMetadata($dataObjectClassName = null)
     protected function getAttributesMetadata($dataObjectClassName)
     {
         $attributes = [];
-        $allAttributes = $this->serviceConfigReader->read();
-        if (isset($allAttributes[$dataObjectClassName])
-            && is_array($allAttributes[$dataObjectClassName])
+        if (empty($this->allAttributes)) {
+            $this->allAttributes = $this->serviceConfigReader->read();
+        }
+        if (isset($this->allAttributes[$dataObjectClassName])
+            && is_array($this->allAttributes[$dataObjectClassName])
         ) {
-            $attributeCodes = array_keys($allAttributes[$dataObjectClassName]);
+            $attributeCodes = array_keys($this->allAttributes[$dataObjectClassName]);
             foreach ($attributeCodes as $attributeCode) {
                 $this->attributeMetadataBuilder->setAttributeCode($attributeCode);
                 $attributes[$attributeCode] = $this->attributeMetadataBuilder->create();