MAGETWO-94306: Fixing issue with getSize function not recalculating after adding filters

Author: Mastiuhin Olexandr

app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php

@@ -653,7 +653,7 @@ public function groupByAttribute($attribute)
      * @param string $bind attribute of the main entity to link with joined $filter
      * @param string $filter primary key for the joined entity (entity_id default)
      * @param string $joinType inner|left
-     * @param null $storeId
+     * @param int|null $storeId
      * @return $this
      * @throws LocalizedException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
@@ -947,8 +947,8 @@ public function load($printQuery = false, $logQuery = false)
     /**
      * Clone and reset collection
      *
-     * @param null $limit
-     * @param null $offset
+     * @param int|null $limit
+     * @param int|null $offset
      * @return Select
      */
     protected function _getAllIdsSelect($limit = null, $offset = null)
@@ -1620,6 +1620,7 @@ public function getLoadedIds()
 
     /**
      * Clear collection
+     *
      * @return $this
      */
     public function clear()
@@ -1630,6 +1631,7 @@ public function clear()
 
     /**
      * Remove all items from collection
+     *
      * @return $this
      */
     public function removeAllItems()
@@ -1653,6 +1655,7 @@ public function removeItemByKey($key)
     }
 
     /**
+     * Returns main table.
      * Returns main table name - extracted from "module/table" style and
      * validated by db adapter
      *

lib/internal/Magento/Framework/Data/Collection/AbstractDb.php

@@ -276,7 +276,7 @@ public function setOrder($field, $direction = self::SORT_ORDER_DESC)
     }
 
     /**
-     * self::setOrder() alias
+     * Sets order and direction.
      *
      * @param string $field
      * @param string $direction
@@ -365,6 +365,7 @@ protected function _renderFilters()
 
     /**
      * Hook for operations before rendering filters
+     *
      * @return void
      */
     protected function _renderFiltersBefore()
@@ -602,6 +603,7 @@ protected function beforeAddLoadedItem(\Magento\Framework\DataObject $item)
     }
 
     /**
+     * Returns an items collection.
      * Returns a collection item that corresponds to the fetched row
      * and moves the internal data pointer ahead
      *