🔃 [EngCom] Public Pull Requests - 2.1-develop

magento-engcom-team · web-flow · commit 46dce627925c · 2018-03-07T23:21:45.000+02:00
Accepted Public Pull Requests: - #13987: Backport of PR-13750 for Magento 2.1: Less clean up (by @Karlasa) - #13980: Backport of PR-13777. Mobile 'Payments methods' step looks bad on mobile (by @Frodigo) Fixed GitHub Issues: - #13315: Mobile "Payment Methods" step looks bad on mobile (reported by @ihor-sviziev) has been fixed in #13980 by @Frodigo in 2.1-develop branch Related commits: 1. 17a707a
diff --git a/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/_minicart.less b/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/_minicart.less
@@ -106,6 +106,10 @@
         .lib-dropdown(
         @_toggle-selector: ~'.action.showcart',
         @_options-selector: ~'.block-minicart',
+        @_dropdown-list-width: 320px,
+        @_dropdown-list-position-right: 0px,
+        @_dropdown-list-pointer-position: right,
+        @_dropdown-list-pointer-position-left-right: 26px,
         @_dropdown-toggle-icon-content: @icon-cart,
         @_dropdown-toggle-active-icon-content: @icon-cart,
         @_dropdown-list-item-padding: false,
@@ -121,22 +125,10 @@
 
         .block-minicart {
             .lib-css(padding, 25px @minicart__padding-horizontal);
-            right: 0;
-            width: 320px;
 
             .block-title {
                 display: none;
             }
-
-            &:after {
-                left: auto;
-                right: 25px;
-            }
-
-            &:before {
-                left: auto;
-                right: 26px;
-            }
         }
 
         .product {
diff --git a/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_payments.less b/app/design/frontend/Magento/blank/Magento_Checkout/web/css/source/module/checkout/_payments.less
@@ -162,6 +162,11 @@
             .lib-css(margin, 0 -(@checkout-payment-method-title-mobile__padding));
         }
 
+        .step-title {
+            .lib-css(padding-left, @checkout-payment-method-title-mobile__padding);
+            .lib-css(padding-right, @checkout-payment-method-title-mobile__padding)
+        }
+
         .payment-method-title {
             .lib-css(padding, @checkout-payment-method-title-mobile__padding)
         }
diff --git a/app/design/frontend/Magento/blank/web/css/source/_navigation.less b/app/design/frontend/Magento/blank/web/css/source/_navigation.less
@@ -93,7 +93,7 @@
         .switcher {
             border-top: 1px solid @color-gray82;
             font-size: 1.6rem;
-            font-weight: 700;
+            font-weight: @font-weight__bold;
             margin: 0;
             padding: .8rem 3.5rem .8rem 2rem;
 
@@ -147,7 +147,7 @@
 
                 &.greet.welcome {
                     border-top: 1px solid @color-gray82;
-                    font-weight: 700;
+                    font-weight: @font-weight__bold;
                     padding: .8rem @indent__base;
                 }
 
@@ -161,7 +161,7 @@
                 .lib-css(color, @navigation-level0-item__color);
                 .lib-css(text-decoration, @navigation-level0-item__text-decoration);
                 display: block;
-                font-weight: 700;
+                font-weight: @font-weight__bold;
                 padding: .8rem @indent__base;
             }
 
diff --git a/app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_minicart.less b/app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/_minicart.less
@@ -109,6 +109,10 @@
         .lib-dropdown(
         @_toggle-selector: ~'.action.showcart',
         @_options-selector: ~'.block-minicart',
+        @_dropdown-list-width: 320px,
+        @_dropdown-list-position-right: 0px,
+        @_dropdown-list-pointer-position: right,
+        @_dropdown-list-pointer-position-left-right: 26px,    
         @_dropdown-toggle-icon-content: @icon-cart,
         @_dropdown-toggle-active-icon-content: @icon-cart,
         @_dropdown-list-item-padding: false,
@@ -124,22 +128,10 @@
 
         .block-minicart {
             .lib-css(padding, 25px @minicart__padding-horizontal);
-            right: 0;
-            width: 320px;
 
             .block-title {
                 display: none;
             }
-
-            &:after {
-                left: auto;
-                right: 25px;
-            }
-
-            &:before {
-                left: auto;
-                right: 26px;
-            }
         }
         .product {
             .actions {
diff --git a/app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_payments.less b/app/design/frontend/Magento/luma/Magento_Checkout/web/css/source/module/checkout/_payments.less
@@ -162,6 +162,11 @@
             .lib-css(margin, 0 -(@checkout-payment-method-title-mobile__padding));
         }
 
+        .step-title {
+            .lib-css(padding-left, @checkout-payment-method-title-mobile__padding);
+            .lib-css(padding-right, @checkout-payment-method-title-mobile__padding)
+        }
+
         .payment-method-title {
             .lib-css(padding, @checkout-payment-method-title-mobile__padding)
         }

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,11 @@`
`162`	`162`	`.lib-css(margin, 0 -(@checkout-payment-method-title-mobile__padding));`
`163`	`163`	`}`
`164`	`164`
	`165`	`+ .step-title {`
	`166`	`+ .lib-css(padding-left, @checkout-payment-method-title-mobile__padding);`
	`167`	`+ .lib-css(padding-right, @checkout-payment-method-title-mobile__padding)`
	`168`	`+ }`
	`169`	`+`
`165`	`170`	`.payment-method-title {`
`166`	`171`	`.lib-css(padding, @checkout-payment-method-title-mobile__padding)`
`167`	`172`	`}`