39525: Modified the code for leading 0 strings as === failing other cart rules conditions

engcom-Dash · engcom-Dash · commit 46caa5e3a8af · 2025-03-17T19:27:29.000+05:30
diff --git a/app/code/Magento/Rule/Model/Condition/AbstractCondition.php b/app/code/Magento/Rule/Model/Condition/AbstractCondition.php
@@ -885,7 +885,10 @@ public function validateAttribute($validatedValue)
     protected function _compareValues($validatedValue, $value, $strict = true)
     {
         if ($strict && is_numeric($validatedValue) && is_numeric($value)) {
-            return $validatedValue === $value;
+            if (preg_match('/^0\d+$/', $validatedValue)) {
+                return $validatedValue === $value;
+            }
+            return $validatedValue == $value;
         }
 
         $validatePattern = preg_quote((string) $validatedValue, '~');

Original file line number	Diff line number	Diff line change
`@@ -885,7 +885,10 @@ public function validateAttribute($validatedValue)`
`885`	`885`	`protected function _compareValues($validatedValue, $value, $strict = true)`
`886`	`886`	`{`
`887`	`887`	`if ($strict && is_numeric($validatedValue) && is_numeric($value)) {`
`888`		`- return $validatedValue === $value;`
	`888`	`+ if (preg_match('/^0\d+$/', $validatedValue)) {`
	`889`	`+ return $validatedValue === $value;`
	`890`	`+ }`
	`891`	`+ return $validatedValue == $value;`
`889`	`892`	`}`
`890`	`893`
`891`	`894`	`$validatePattern = preg_quote((string) $validatedValue, '~');`