MC-17592: End-to-end integration to test order with Payflow Link

- review comments and static failure fix

Author: dthampy

dev/tests/integration/testsuite/Magento/Paypal/_files/order_payflow_link_with_payment.php

@@ -11,7 +11,6 @@
 include __DIR__ . '/../../GraphQl/Quote/_files/set_new_billing_address.php';
 include __DIR__ . '/../../GraphQl/Quote/_files/set_flatrate_shipping_method.php';
 
-
 use Magento\Paypal\Model\Config;
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\Sales\Api\Data\OrderInterface;
@@ -51,7 +50,6 @@
     ->setBaseAmountAuthorized(30)
     ->setAdditionalInformation(
         [
-
         'cancel_url'=> $baseUrl .'paypal/payflow/cancelPayment',
         'return_url'=> $baseUrl .'paypal/payflow/returnUrl',
         'secure_token_id' => 'mysecuretokenId',

dev/tests/integration/testsuite/Magento/Paypal/_files/order_payflow_link_with_payment_rollback.php

@@ -16,19 +16,5 @@
 foreach ($orderCollection as $order) {
     $order->delete();
 }
-
-/** @var $product \Magento\Catalog\Model\Product */
-$productCollection = Bootstrap::getObjectManager()->create(
-    \Magento\Catalog\Model\ResourceModel\Product\Collection::class
-);
-foreach ($productCollection as $product) {
-    $product->delete();
-}
-
-/** @var \Magento\CatalogInventory\Model\StockRegistryStorage $stockRegistryStorage */
-$stockRegistryStorage = Bootstrap::getObjectManager()
-    ->get(\Magento\CatalogInventory\Model\StockRegistryStorage::class);
-$stockRegistryStorage->clean();
-
 $registry->unregister('isSecureArea');
 $registry->register('isSecureArea', false);

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Customer/PlaceOrderWithPayflowLinkTest.php

@@ -154,7 +154,7 @@ public function testResolvePlaceOrderWithPayflowLinkForCustomer(): void
         $this->request->setPathInfo('/graphql');
         $this->request->setMethod('POST');
         $this->request->setContent($postData);
-        
+
         /** @var \Magento\Integration\Model\Oauth\Token $tokenModel */
         $tokenModel = $this->objectManager->create(\Magento\Integration\Model\Oauth\Token::class);
         $customerToken = $tokenModel->createCustomerToken(1)->getToken();

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PlaceOrderWithPayflowLinkTest.php

@@ -57,7 +57,6 @@ class PlaceOrderWithPayflowLinkTest extends TestCase
     /** @var  Request|MockObject */
     private $payflowRequest;
 
-
     protected function setUp()
     {
         parent::setUp();
@@ -284,16 +283,23 @@ public function testResolveWithPayflowLinkDeclined(): void
             );
         $this->gateway->method('postRequest')
             /** @var DataObject $linkRequest */
-            ->with(self::callback(function ($linkRequest)  {
-                self::assertEquals('test_quote', $linkRequest['invnum']);
-                return true;
-            }))->willThrowException($exception);
+            ->with(
+                self::callback(
+                    function ($linkRequest) {
+                        self::assertEquals('test_quote', $linkRequest['invnum']);
+                        return true;
+                    }
+                )
+            )->willThrowException($exception);
 
         $response = $this->graphqlController->dispatch($this->request);
         $responseData = $this->json->unserialize($response->getContent());
         $this->assertArrayHasKey('errors', $responseData);
         $actualError = $responseData['errors'][0];
-        $this->assertEquals('Unable to place order: Declined response message from PayPal gateway', $actualError['message']);
+        $this->assertEquals(
+            'Unable to place order: Declined response message from PayPal gateway',
+            $actualError['message']
+        );
         $this->assertEquals(GraphQlInputException::EXCEPTION_CATEGORY, $actualError['category']);
     }