MTA-1397: Update setValue() method for basic typified elements

- Fixed logical and code style errors

Author: Oleksandr Manchenko

dev/tests/functional/tests/app/Magento/Customer/Test/Block/Adminhtml/Edit/CustomerForm.php

@@ -21,7 +21,7 @@ class CustomerForm extends FormTabs
      *
      * @var string
      */
-    protected $loader = '[data-role="spinner"]';
+    protected $spinner = '[data-role="spinner"]';
 
     /**
      * Customer form to load.
@@ -31,32 +31,34 @@ class CustomerForm extends FormTabs
     protected $activeFormTab = '.entry-edit.form-inline [data-bind="visible: active"]:not([style="display: none;"])';
 
     /**
-     * Field label on customer form.
+     * Field wrapper with label on form.
      *
      * @var string
      */
-    protected  $fieldLabel = './/*[contains(@class, "form__field")]/*[contains(@class,"label")]';
+    protected $fieldLabel = './/*[contains(@class, "form__field")]/*[contains(@class,"label")]';
 
     /**
-     * Field with absent label on customer form.
+     * Field wrapper with absent label on form.
      *
      * @var string
      */
-    protected  $fieldLabelAbsent = './/*[contains(@class, "form__field") and not(./*[contains(@class,"label")]/*)]';
+    protected $fieldLabelAbsent = './/*[contains(@class, "form__field") and not(./*[contains(@class,"label")]/*)]';
 
     /**
-     * Wrapper for field on customer form.
+     * Field wrapper with control block on form.
      *
      * @var string
      */
     protected $fieldWrapperControl = './/*[contains(@class, "form__field")]/*[contains(@class,"control")]';
 
+    // @codingStandardsIgnoreStart
     /**
-     * Wrapper with absent field on customer form.
+     * Field wrapper with absent control block on form.
      *
      * @var string
      */
     protected $fieldWrapperControlAbsent = './/*[contains(@class, "form__field") and not(./input or ./*[contains(@class,"control")]/*)]';
+    // @codingStandardsIgnoreEnd
 
     /**
      * Fill Customer forms on tabs by customer, addresses data.
@@ -67,8 +69,10 @@ class CustomerForm extends FormTabs
      */
     public function fillCustomer(FixtureInterface $customer, $address = null)
     {
-        $isHasData = ($customer instanceof InjectableFixture) ? $customer->hasData() : true;
         $this->waitForm();
+        $this->waitFields();
+
+        $isHasData = ($customer instanceof InjectableFixture) ? $customer->hasData() : true;
         if ($isHasData) {
             parent::fill($customer);
         }
@@ -89,8 +93,9 @@ public function fillCustomer(FixtureInterface $customer, $address = null)
      */
     public function updateCustomer(FixtureInterface $customer, $address = null)
     {
-        $isHasData = ($customer instanceof InjectableFixture) ? $customer->hasData() : true;
         $this->waitForm();
+
+        $isHasData = ($customer instanceof InjectableFixture) ? $customer->hasData() : true;
         if ($isHasData) {
             parent::fill($customer);
         }
@@ -130,14 +135,25 @@ public function getDataCustomer(FixtureInterface $customer, $address = null)
      */
     protected function waitForm()
     {
-        $this->waitForElementNotVisible($this->loader);
+        $this->waitForElementNotVisible($this->spinner);
         $this->waitForElementVisible($this->activeFormTab);
+    }
 
+    /**
+     * Wait for User before fill form which calls JS validation on correspondent fields of form.
+     * See details in MAGETWO-31435.
+     *
+     * @return void
+     */
+    protected function waitFields()
+    {
+        /* Wait for field label is visible in the form */
         $this->waitForElementVisible($this->fieldLabel, Locator::SELECTOR_XPATH);
+        /* Wait for render all field's labels(assert that absent field without label) in the form */
         $this->waitForElementNotVisible($this->fieldLabelAbsent, Locator::SELECTOR_XPATH);
+        /* Wait for field's control block is visible in the form */
         $this->waitForElementVisible($this->fieldWrapperControl, Locator::SELECTOR_XPATH);
+        /* Wait for render all field's control blocks(assert that absent field without control block) in the form */
         $this->waitForElementNotVisible($this->fieldWrapperControlAbsent, Locator::SELECTOR_XPATH);
-
-        usleep(500000);
     }
 }