Merge pull request #343 from magento-webdev/PR

[UI] Sprint 38 + Bugfixes

Author: Momotenko,Natalia(nmomotenko)

Gruntfile.js

@@ -68,12 +68,17 @@ module.exports = function (grunt) {
             'less:luma',
             'less:backend'
         ],
+
         /**
          * Documentation
          */
         documentation: [
+            'replace:documentation',
             'less:documentation',
             'styledocco:documentation',
+            'usebanner:documentationCss',
+            'usebanner:documentationLess',
+            'usebanner:documentationHtml',
             'clean:var',
             'clean:pub'
         ],
@@ -82,12 +87,6 @@ module.exports = function (grunt) {
             'mage-minify:legacy'
         ],
 
-        'documentation-banners': [
-            'usebanner:documentationCss',
-            'usebanner:documentationLess',
-            'usebanner:documentationHtml'
-        ],
-
         spec: function (theme) {
             var runner = require('./dev/tests/js/jasmine/spec_runner');
 

app/code/Magento/Backend/Controller/Adminhtml/Index/GlobalSearch.php

@@ -48,7 +48,7 @@ public function execute()
             $items[] = [
                 'id' => 'error',
                 'type' => __('Error'),
-                'name' => __('Access Denied'),
+                'name' => __('Access Denied.'),
                 'description' => __('You need more permissions to do this.'),
             ];
         } else {

app/code/Magento/Backend/view/adminhtml/templates/admin/access_denied.phtml

@@ -15,9 +15,9 @@
 <h1 class="page-heading"><?php echo __('Access denied') ?></h1>
 <?php if (!$block->hasAvailableResources()): ?>
 <p>
-<?php echo __('Please try to log out and sign in again.') ?><br/>
+<?php echo __('Please try to sign out and sign in again.') ?><br/>
 <?php echo __('If you continue to receive this message, please contact the store owner.') ?>
 </p>
 <?php else: ?>
-<p><?php echo __('Access denied.') ?></p>
+<p><?php echo __('You need more permissions to access this.') ?></p>
 <?php endif?>

app/code/Magento/Backend/view/adminhtml/templates/media/uploader.phtml

@@ -73,7 +73,7 @@ require([
                 $('#' + data.fileId)
                     .delay(2000)
                     .hide('highlight');
-                alert($.mage.__('File extension not known or unsupported type.'));
+                alert($.mage.__('We don\'t recognize or support this file extension type.'));
             }
             $('#' + data.fileId).remove();
         },

app/code/Magento/Backend/view/adminhtml/templates/menu.phtml

@@ -8,7 +8,6 @@
 
 ?>
 
-
 <nav data-mage-init='{"globalNavigation": {}}' class="admin__menu" role="navigation">
     <?php echo $block->renderNavigation($block->getMenuModel(), 0, 12); ?>
 </nav>

app/code/Magento/Bundle/Model/Product/Type.php

@@ -1319,7 +1319,7 @@ protected function checkIsResult($_result)
 
         if (!isset($_result[0])) {
             throw new \Magento\Framework\Exception\LocalizedException(
-                __('We cannot add this item to your shopping cart.')
+                __('We can\'t add this item to your cart right now.')
             );
         }
     }

app/code/Magento/Bundle/Test/Unit/Model/Product/TypeTest.php

@@ -695,7 +695,7 @@ function ($key) use ($optionCollection, $selectionCollection) {
             ->willReturn(3.14);
 
         $result = $this->model->prepareForCartAdvanced($buyRequest, $product);
-        $this->assertEquals('We cannot add this item to your shopping cart.', $result);
+        $this->assertEquals('We can\'t add this item to your cart right now.', $result);
     }
 
     /**

app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php

@@ -85,7 +85,7 @@ protected function _prepareForm()
                 'label' => __('Attribute Code'),
                 'title' => __('Attribute Code'),
                 'note' => __(
-                    'For internal use. Must be unique with no spaces. Maximum length of attribute code must be less than %1 symbols',
+                    'This is used internally. Make sure you don\'t use spaces or more than %1 symbols.',
                     \Magento\Eav\Model\Entity\Attribute::ATTRIBUTE_CODE_MAX_LENGTH
                 ),
                 'class' => $validateClass

app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php

@@ -89,15 +89,16 @@ public function getValuesHtml()
                     $type = 'radio';
                     $class = 'radio admin__control-radio';
                     if (!$_option->getIsRequire()) {
-                        $selectHtml .= '<div class="field admin__field choice"><input type="radio" id="options_' .
+                        $selectHtml .= '<div class="field choice admin__field admin__field-option">' .
+                            '<input type="radio" id="options_' .
                             $_option->getId() .
                             '" class="' .
                             $class .
                             ' product-custom-option" name="options[' .
                             $_option->getId() .
                             ']"' .
                             ($this->getSkipJsReloadPrice() ? '' : ' onclick="opConfig.reloadPrice()"') .
-                            ' value="" checked="checked" /><label class="label" for="options_' .
+                            ' value="" checked="checked" /><label class="label admin__field-label" for="options_' .
                             $_option->getId() .
                             '"><span>' .
                             __('None') . '</span></label></div>';
@@ -153,7 +154,7 @@ public function getValuesHtml()
                     ' price="' .
                     $this->pricingHelper->currencyByStore($_value->getPrice(true), $store, false) .
                     '" />' .
-                    '<label class="label" for="options_' .
+                    '<label class="label admin__field-label" for="options_' .
                     $_option->getId() .
                     '_' .
                     $count .

app/code/Magento/Catalog/Controller/Adminhtml/Product/Set/Delete.php

@@ -39,7 +39,7 @@ public function execute()
             $this->messageManager->addSuccess(__('The attribute set has been removed.'));
             $resultRedirect->setPath('catalog/*/');
         } catch (\Exception $e) {
-            $this->messageManager->addError(__('An error occurred while deleting this set.'));
+            $this->messageManager->addError(__('We can\'t delete this set right now.'));
             $resultRedirect->setUrl($this->_redirect->getRedirectUrl($this->getUrl('*')));
         }
         return $resultRedirect;