Skip to content

Commit 46107da

Browse files
ENGCOM-2910: Fix for invalid JSON if image label contains HTML markup, example " #17848
- Merge Pull Request #17848 from jeroenschipper/magento2:escapeMediaGalleryJsonFix - Merged commits: 1. f185393
2 parents 5c70bb7 + f185393 commit 46107da

File tree

1 file changed

+1
-1
lines changed
  • app/code/Magento/ProductVideo/view/adminhtml/templates/helper

1 file changed

+1
-1
lines changed

app/code/Magento/ProductVideo/view/adminhtml/templates/helper/gallery.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $elementToggleCode = $element->getToggleCode() ? $element->getToggleCode() : 'to
3434
class="gallery"
3535
data-mage-init='{"openVideoModal":{}}'
3636
data-parent-component="<?= $block->escapeHtml($block->getData('config/parentComponent')) ?>"
37-
data-images="<?= $block->escapeHtml($block->getImagesJson()) ?>"
37+
data-images="<?= $block->escapeHtmlAttr($block->getImagesJson()) ?>"
3838
data-types="<?= $block->escapeHtml(
3939
$this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($block->getImageTypes())
4040
) ?>"

0 commit comments

Comments
 (0)