MAGETWO-45073: PHP notice during to create Text Swatch product attribute

Author: okarpenko

app/code/Magento/Swatches/Model/Plugin/EavAttribute.php

@@ -7,6 +7,7 @@
 
 use Magento\Catalog\Model\ResourceModel\Eav\Attribute;
 use Magento\Swatches\Model\Swatch;
+use Magento\Framework\Exception\InputException;
 
 /**
  * Plugin model for Catalog Resource Attribute
@@ -49,19 +50,27 @@ class EavAttribute
      */
     protected $isSwatchExists;
 
+    /**
+     * @var \Magento\Framework\Message\ManagerInterface
+     */
+    protected $messageManager;
+
     /**
      * @param \Magento\Swatches\Model\ResourceModel\Swatch\CollectionFactory $collectionFactory
      * @param \Magento\Swatches\Model\SwatchFactory $swatchFactory
      * @param \Magento\Swatches\Helper\Data $swatchHelper
+     * @param \Magento\Framework\Message\ManagerInterface $messageManager
      */
     public function __construct(
         \Magento\Swatches\Model\ResourceModel\Swatch\CollectionFactory $collectionFactory,
         \Magento\Swatches\Model\SwatchFactory $swatchFactory,
-        \Magento\Swatches\Helper\Data $swatchHelper
+        \Magento\Swatches\Helper\Data $swatchHelper,
+        \Magento\Framework\Message\ManagerInterface $messageManager
     ) {
         $this->swatchCollectionFactory = $collectionFactory;
         $this->swatchFactory = $swatchFactory;
         $this->swatchHelper = $swatchHelper;
+        $this->messageManager = $messageManager;
     }
 
     /**
@@ -72,13 +81,22 @@ public function __construct(
      */
     public function beforeSave(Attribute $attribute)
     {
-        if ($this->swatchHelper->isSwatchAttribute($attribute)) {
+        if ($this->swatchHelper->isSwatchAttribute($attribute) && $this->validateOptions($attribute)) {
             $this->setProperOptionsArray($attribute);
             $this->swatchHelper->assembleAdditionalDataEavAttribute($attribute);
         }
         $this->convertSwatchToDropdown($attribute);
     }
 
+    protected function validateOptions(Attribute $attribute)
+    {
+        $attributeSavedOptions = $attribute->getSource()->getAllOptions(false);
+        if (!count($attributeSavedOptions)) {
+            throw new InputException(__('Admin is a required field in the each row'));
+        }
+        return true;
+    }
+
     /**
      * Swatch save operations
      *
@@ -154,7 +172,7 @@ protected function processSwatchOptions(Attribute $attribute)
 
         if (!empty($optionsArray) && is_array($optionsArray)) {
             $optionsArray = $this->prepareOptionIds($optionsArray);
-            $attributeSavedOptions = $attribute->getSource()->getAllOptions();
+            $attributeSavedOptions = $attribute->getSource()->getAllOptions(false);
             $this->prepareOptionLinks($optionsArray, $attributeSavedOptions);
         }
 

app/code/Magento/Swatches/Test/Unit/Model/Plugin/EavAttributeTest.php

@@ -54,6 +54,9 @@ class EavAttributeTest extends \PHPUnit_Framework_TestCase
     /** @var array */
     private $dependencyArray = [];
 
+    /** @var \Magento\Eav\Model\Entity\Attribute\Source\AbstractSource|\PHPUnit_Framework_MockObject_MockObject */
+    protected $source;
+
     public function setUp()
     {
         $this->attribute = $this->getMock('\Magento\Catalog\Model\ResourceModel\Eav\Attribute', [], [], '', false);
@@ -87,6 +90,13 @@ public function setUp()
                 'swatchHelper' => $this->swatchHelper,
             ]
         );
+        $this->source = $this->getMockForAbstractClass(
+            'Magento\Eav\Model\Entity\Attribute\Source\AbstractSource',
+            [],
+            '',
+            false
+        );
+
 
         $this->optionIds = [
             'value' => ['option 89' => 'test 1', 'option 114' => 'test 2', 'option 170' => 'test 3'],
@@ -117,6 +127,19 @@ public function testBeforeSaveVisualSwatch()
                 ['swatch', self::ATTRIBUTE_SWATCH_VALUE]
             );
 
+        $this->attribute->expects($this->once())
+            ->method('getSource')
+            ->willReturn($this->source);
+        $this->source->expects($this->once())
+            ->method('getAllOptions')
+            ->with(false)
+            ->willReturn([
+                [
+                    'value' => 'value',
+                    'label' => 'label'
+                ]
+            ]);
+
         $this->swatchHelper->expects($this->once())->method('assembleAdditionalDataEavAttribute')
             ->with($this->attribute);
         $this->swatchHelper->expects($this->once())->method('isVisualSwatch')
@@ -153,6 +176,19 @@ public function testBeforeSaveTextSwatch()
                 ['swatch', self::ATTRIBUTE_SWATCH_VALUE]
             );
 
+        $this->attribute->expects($this->once())
+            ->method('getSource')
+            ->willReturn($this->source);
+        $this->source->expects($this->once())
+            ->method('getAllOptions')
+            ->with(false)
+            ->willReturn([
+                [
+                    'value' => 'value',
+                    'label' => 'label'
+                ]
+            ]);
+
         $this->swatchHelper->expects($this->once())->method('assembleAdditionalDataEavAttribute')
             ->with($this->attribute);
         $this->swatchHelper->expects($this->once())->method('isVisualSwatch')
@@ -168,6 +204,27 @@ public function testBeforeSaveTextSwatch()
         $this->eavAttribute->beforeSave($this->attribute);
     }
 
+    /**
+     * @expectedException \Magento\Framework\Exception\InputException
+     * @expectedExceptionMessage Admin is a required field in the each row
+     */
+    public function testBeforeSaveWithFailedValidation()
+    {
+        $this->swatchHelper->expects($this->once())->method('isSwatchAttribute')
+            ->with($this->attribute)
+            ->willReturn(true);
+
+        $this->attribute->expects($this->once())
+            ->method('getSource')
+            ->willReturn($this->source);
+        $this->source->expects($this->once())
+            ->method('getAllOptions')
+            ->with(false)
+            ->willReturn([]);
+
+        $this->eavAttribute->beforeSave($this->attribute);
+    }
+
     public function testBeforeSaveNotSwatch()
     {
         $additionalData = [