Skip to content

Commit 4513145

Browse files
committed
Merge branch 'magento-commerce:2.4-develop' into MC-40556
2 parents 2ae8844 + 710b9cc commit 4513145

File tree

17 files changed

+7473
-5810
lines changed

17 files changed

+7473
-5810
lines changed

app/code/Magento/AdminAnalytics/etc/csp_whitelist.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@
1111
<policy id="script-src">
1212
<values>
1313
<value id="adobedtm" type="host">assets.adobedtm.com</value>
14+
<value id="adobe" type="host">*.adobe.com</value>
15+
</values>
16+
</policy>
17+
<policy id="style-src">
18+
<values>
19+
<value id="adobe" type="host">*.adobe.com</value>
1420
</values>
1521
</policy>
1622
<policy id="img-src">
@@ -19,6 +25,7 @@
1925
<value id="omtrdc" type="host">amcglobal.sc.omtrdc.net</value>
2026
<value id="dpmdemdex" type="host">dpm.demdex.net</value>
2127
<value id="everesttech" type="host">cm.everesttech.net</value>
28+
<value id="adobe" type="host">*.adobe.com</value>
2229
</values>
2330
</policy>
2431
<policy id="connect-src">
@@ -27,9 +34,15 @@
2734
<value id="omtrdc" type="host">amcglobal.sc.omtrdc.net</value>
2835
</values>
2936
</policy>
37+
<policy id="media-src">
38+
<values>
39+
<value id="adobe" type="host">*.adobe.com</value>
40+
</values>
41+
</policy>
3042
<policy id="frame-src">
3143
<values>
3244
<value id="amcdemdex" type="host">fast.amc.demdex.net</value>
45+
<value id="adobe" type="host">*.adobe.com</value>
3346
</values>
3447
</policy>
3548
</policies>

app/code/Magento/Catalog/Test/Mftf/Test/AdminSimpleSetEditRelatedProductsTest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@
100100
<conditionalClick selector="{{AdminProductFormRelatedUpSellCrossSellSection.relatedDropdown}}" dependentSelector="{{AdminProductFormRelatedUpSellCrossSellSection.relatedDependent}}" visible="false" stepKey="openDropDownIfClosedRelatedSee2"/>
101101
<see selector="{{AdminProductFormRelatedUpSellCrossSellSection.selectedRelatedProduct}}" userInput="$$simpleProduct6.name$$" stepKey="seeSixthRelatedProduct"/>
102102
<selectOption selector=".admin__collapsible-block-wrapper[data-index='related'] .admin__control-select" userInput="5" stepKey="selectFivePerPage"/>
103+
<waitForPageLoad stepKey="waitForLoadingAfterSelectFivePerPage"/>
103104
<dontSee selector="{{AdminProductFormRelatedUpSellCrossSellSection.selectedRelatedProduct}}" userInput="$$simpleProduct6.name$$" stepKey="dontSeeSixthRelatedProduct"/>
104105

105106
<!--See related product in storefront-->

app/code/Magento/GiftMessage/view/frontend/web/template/gift-message-item-level.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,17 @@
3333
<!-- ko text: getObservable('message') --><!-- /ko -->
3434
</div>
3535
<!-- /ko -->
36-
36+
3737
<div class="actions-toolbar">
3838
<div class="secondary">
3939
<button type="submit" class="action action-edit" data-bind="
4040
click: $data.editOptions.bind($data),
41-
attr: {title: $t('Edit')">
41+
attr: {title: $t('Edit')}">
4242
<span data-bind="i18n: 'Edit'"></span>
4343
</button>
4444
<button class="action action-delete" data-bind="
4545
click: $data.deleteOptions.bind($data),
46-
attr: {title: $t('Delete')">
46+
attr: {title: $t('Delete')}">
4747
<span data-bind="i18n: 'Delete'"></span>
4848
</button>
4949
</div>

app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ define([
1313
'uiLayout',
1414
'uiCollection',
1515
'uiRegistry',
16-
'mage/translate'
17-
], function (ko, utils, _, layout, uiCollection, registry, $t) {
16+
'mage/translate',
17+
'jquery'
18+
], function (ko, utils, _, layout, uiCollection, registry, $t, $) {
1819
'use strict';
1920

2021
/**
@@ -975,6 +976,18 @@ define([
975976
this._reducePages();
976977
},
977978

979+
/**
980+
* Update page size based on select change event.
981+
* The value needs to be retrieved from select as ko value handler is executed after the event handler.
982+
*
983+
* @param {Object} component
984+
* @param {jQuery.Event} event
985+
*/
986+
updatePageSize: function (component, event) {
987+
this.pageSize = $(event.target).val();
988+
this.reload();
989+
},
990+
978991
/**
979992
* Destroy all dynamic-rows elems
980993
*

app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/optgroup.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ define([
1919
ko.bindingHandlers.optgroup = {
2020
/**
2121
* @param {*} element
22-
* @returns {Object}
2322
*/
2423
init: function (element) {
2524
if (ko.utils.tagNameLower(element) !== 'select') {
@@ -30,11 +29,6 @@ define([
3029
while (element.length > 0) {
3130
element.remove(0);
3231
}
33-
34-
// Ensures that the binding processor doesn't try to bind the options
35-
return {
36-
'controlsDescendantBindings': true
37-
};
3832
},
3933

4034
/**
@@ -333,5 +327,4 @@ define([
333327
}
334328
}
335329
};
336-
ko.bindingHandlers.selectedOptions.after.push('optgroup');
337330
});

app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/scope.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ define([
2929
$t: $t
3030
});
3131

32-
ko.utils.arrayForEach(el.childNodes, ko.cleanNode);
32+
ko.utils.arrayForEach(ko.virtualElements.childNodes(el), ko.cleanNode);
3333

3434
ko.applyBindingsToDescendants(component, el);
3535
}

app/code/Magento/Ui/view/base/web/templates/dynamic-rows/templates/grid.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<div class="admin__field-control" data-role="grid-wrapper">
1818
<div class="admin__control-table-pagination" visible="!!$data.getRecordCount()">
1919
<div class="admin__data-grid-pager-wrap">
20-
<select class="admin__control-select" data-bind="value:pageSize, event:{change: reload}">
20+
<select class="admin__control-select" data-bind="value:pageSize, event:{change: updatePageSize}">
2121
<option value="5">5</option>
2222
<option value="20" selected="selected">20</option>
2323
<option value="30">30</option>

app/code/Magento/Ui/view/frontend/web/templates/form/field.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,3 @@
5050
<!-- /ko -->
5151
</div>
5252
</div>
53-
<!-- /ko -->

composer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,9 @@
9393
"phpmd/phpmd": "^2.8.0",
9494
"phpstan/phpstan": "^0.12.77",
9595
"phpunit/phpunit": "^9",
96-
"sebastian/phpcpd": "~5.0.0",
97-
"squizlabs/php_codesniffer": "~3.5.4"
96+
"sebastian/phpcpd": "^6.0.3",
97+
"squizlabs/php_codesniffer": "~3.5.4",
98+
"symfony/finder": "^5.2"
9899
},
99100
"suggest": {
100101
"ext-pcntl": "Need for run processes in parallel mode"

0 commit comments

Comments
 (0)