GraphQL-118: [Mutations] Cart Operations > Create Empty Cart

Valeriy Nayda · Valeriy Nayda · commit 439df246286a · 2018-09-03T11:57:10.000+03:00
-- Slight fixes
diff --git a/app/code/Magento/Quote/Model/MaskedQuoteIdToQuoteId.php b/app/code/Magento/Quote/Model/MaskedQuoteIdToQuoteId.php
@@ -43,7 +43,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritDoc}
+     * @inheritDoc
      */
     public function execute(string $maskedQuoteId): int
     {
@@ -52,6 +52,6 @@ public function execute(string $maskedQuoteId): int
 
         $cart = $this->cartRepository->get($quoteIdMask->getQuoteId());
 
-        return (int) $cart->getId();
+        return (int)$cart->getId();
     }
 }
diff --git a/app/code/Magento/Quote/Model/QuoteIdToMaskedQuoteId.php b/app/code/Magento/Quote/Model/QuoteIdToMaskedQuoteId.php
@@ -34,7 +34,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritDoc}
+     * @inheritDoc
      */
     public function execute(int $quoteId): string
     {
diff --git a/app/code/Magento/QuoteGraphQl/Model/Resolver/Cart/CreateEmptyCart.php b/app/code/Magento/QuoteGraphQl/Model/Resolver/Cart/CreateEmptyCart.php
@@ -18,7 +18,7 @@
 use Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface;
 
 /**
- * {@inheritdoc}
+ * @inheritdoc
  */
 class CreateEmptyCart implements ResolverInterface
 {
@@ -69,23 +69,21 @@ public function __construct(
     }
 
     /**
-     * {@inheritDoc}
+     * @inheritDoc
      */
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null) : Value
     {
         $customerId = $this->userContext->getUserId();
 
-        if ($customerId) {
+        if (null !== $customerId) {
             $quoteId = $this->cartManagement->createEmptyCartForCustomer($customerId);
             $maskedQuoteId = $this->quoteIdToMaskedId->execute($quoteId);
         } else {
             $maskedQuoteId = $this->guestCartManagement->createEmptyCart();
         }
 
-        $result = function () use ($maskedQuoteId) {
+        return $this->valueFactory->create(function () use ($maskedQuoteId) {
             return $maskedQuoteId;
-        };
-
-        return $this->valueFactory->create($result);
+        });
     }
 }
diff --git a/app/code/Magento/QuoteGraphQl/etc/module.xml b/app/code/Magento/QuoteGraphQl/etc/module.xml
@@ -6,9 +6,5 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Magento_QuoteGraphQl">
-        <sequence>
-            <module name="Magento_GraphQl"/>
-        </sequence>
-    </module>
+    <module name="Magento_QuoteGraphQl"/>
 </config>

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function __construct(`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/**`
`46`		`- * {@inheritDoc}`
	`46`	`+ * @inheritDoc`
`47`	`47`	`*/`
`48`	`48`	`public function execute(string $maskedQuoteId): int`
`49`	`49`	`{`
`@@ -52,6 +52,6 @@ public function execute(string $maskedQuoteId): int`
`52`	`52`
`53`	`53`	`$cart = $this->cartRepository->get($quoteIdMask->getQuoteId());`
`54`	`54`
`55`		`- return (int) $cart->getId();`
	`55`	`+ return (int)$cart->getId();`
`56`	`56`	`}`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`/**`
`37`		`- * {@inheritDoc}`
	`37`	`+ * @inheritDoc`
`38`	`38`	`*/`
`39`	`39`	`public function execute(int $quoteId): string`
`40`	`40`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`use Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface;`
`19`	`19`
`20`	`20`	`/**`
`21`		`- * {@inheritdoc}`
	`21`	`+ * @inheritdoc`
`22`	`22`	`*/`
`23`	`23`	`class CreateEmptyCart implements ResolverInterface`
`24`	`24`	`{`
`@@ -69,23 +69,21 @@ public function __construct(`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`/**`
`72`		`- * {@inheritDoc}`
	`72`	`+ * @inheritDoc`
`73`	`73`	`*/`
`74`	`74`	`public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null) : Value`
`75`	`75`	`{`
`76`	`76`	`$customerId = $this->userContext->getUserId();`
`77`	`77`
`78`		`- if ($customerId) {`
	`78`	`+ if (null !== $customerId) {`
`79`	`79`	`$quoteId = $this->cartManagement->createEmptyCartForCustomer($customerId);`
`80`	`80`	`$maskedQuoteId = $this->quoteIdToMaskedId->execute($quoteId);`
`81`	`81`	`} else {`
`82`	`82`	`$maskedQuoteId = $this->guestCartManagement->createEmptyCart();`
`83`	`83`	`}`
`84`	`84`
`85`		`- $result = function () use ($maskedQuoteId) {`
	`85`	`+ return $this->valueFactory->create(function () use ($maskedQuoteId) {`
`86`	`86`	`return $maskedQuoteId;`
`87`		`- };`
`88`		`-`
`89`		`- return $this->valueFactory->create($result);`
	`87`	`+ });`
`90`	`88`	`}`
`91`	`89`	`}`