Skip to content

Commit 4361244

Browse files
#23253: Added support for float numbers without leading zero.
1 parent 14fa20e commit 4361244

File tree

2 files changed

+9
-2
lines changed
  • app/code/Magento/Ui/view/base/web/js/lib/validation
  • dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/lib/validation

2 files changed

+9
-2
lines changed

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,8 @@ define([
651651
'validate-number': [
652652
function (value) {
653653
return utils.isEmptyNoTrim(value) ||
654-
!isNaN(utils.parseNumber(value)) && /^\s*-?\d{1,}(?:[.,|'|\s]\d{1,})*(?:[.,|'|\s]\d{2})?-?\s*$/.test(value);
654+
!isNaN(utils.parseNumber(value)) &&
655+
/^\s*-?\d*(?:[.,|'|\s]\d+)*(?:[.,|'|\s]\d{2})?-?\s*$/.test(value);
655656
},
656657
$.mage.__('Please enter a valid number in this field.')
657658
],

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/lib/validation/rules.test.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ define([
5858
expect(rules['validate-number'].handler(value)).toBe(true);
5959
});
6060

61+
it('Check on float without leading zero', function () {
62+
var value = '.50';
63+
64+
expect(rules['validate-number'].handler(value)).toBe(true);
65+
});
66+
6167
it('Check on formatted float', function () {
6268
var value = '1,000,000.50';
6369

@@ -81,7 +87,7 @@ define([
8187

8288
expect(rules['validate-number'].handler(value)).toBe(true);
8389
});
84-
90+
8591
it('Check on not a number', function () {
8692
var value = 'string';
8793

0 commit comments

Comments
 (0)