Skip to content

Commit 4312881

Browse files
author
Victor Rad
committed
MAGETWO-36951: Decrease CRAP of Magento\Review\Model\Resource\Review::aggregate
- CR fix
1 parent a62dc7d commit 4312881

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

app/code/Magento/Review/Model/Resource/Review.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,8 @@ public function aggregate($object)
338338
* Aggregate review summary
339339
*
340340
* @param \Magento\Framework\Model\AbstractModel $object
341-
* @param $ratingSummaryObject
341+
* @param \Magento\Framework\Data\Collection\Db $ratingSummaryObject
342+
* @return void
342343
*/
343344
protected function aggregateReviewSummary($object, $ratingSummaryObject)
344345
{
@@ -381,6 +382,7 @@ protected function aggregateReviewSummary($object, $ratingSummaryObject)
381382
*
382383
* @param array|bool $oldData
383384
* @param \Magento\Framework\Object $data
385+
* @return void
384386
*/
385387
protected function writeReviewSummary($oldData, \Magento\Framework\Object $data)
386388
{

dev/tests/integration/testsuite/Magento/Review/_files/customer_review_with_rating.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@
4343
->setPageSize(2)
4444
->setCurPage(1);
4545

46-
foreach($ratingCollection as $rating) {
46+
foreach ($ratingCollection as $rating) {
4747
$rating->setStores([$storeId])->setIsActive(1)->save();
4848
}
4949

50-
foreach($ratingCollection as $rating) {
51-
$ratingOption = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
52-
'\Magento\Review\Model\Rating\Option'
53-
)->getCollection()
50+
foreach ($ratingCollection as $rating) {
51+
$ratingOption = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
52+
->create('\Magento\Review\Model\Rating\Option')
53+
->getCollection()
5454
->setPageSize(1)
5555
->setCurPage(2)
5656
->addRatingFilter($rating->getId())

0 commit comments

Comments
 (0)