Fixing phpcs and phpcbf

Author: MaxSouza

app/code/Magento/SalesRule/Model/RulesApplier.php

@@ -7,8 +7,10 @@
 namespace Magento\SalesRule\Model;
 
 use Magento\Quote\Model\Quote\Address;
+use Magento\Quote\Model\Quote\Item\AbstractItem;
 use Magento\SalesRule\Model\Quote\ChildrenValidationLocator;
 use Magento\Framework\App\ObjectManager;
+use Magento\SalesRule\Model\ResourceModel\Rule\Collection;
 use Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory;
 
 /**
@@ -42,9 +44,9 @@ class RulesApplier
 
     /**
      * @param \Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory $calculatorFactory
-     * @param \Magento\Framework\Event\ManagerInterface $eventManager
-     * @param \Magento\SalesRule\Model\Utility $utility
-     * @param ChildrenValidationLocator|null $childrenValidationLocator
+     * @param \Magento\Framework\Event\ManagerInterface                       $eventManager
+     * @param \Magento\SalesRule\Model\Utility                                $utility
+     * @param ChildrenValidationLocator|null                                  $childrenValidationLocator
      */
     public function __construct(
         \Magento\SalesRule\Model\Rule\Action\Discount\CalculatorFactory $calculatorFactory,
@@ -62,18 +64,18 @@ public function __construct(
     /**
      * Apply rules to current order item
      *
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
-     * @param \Magento\SalesRule\Model\ResourceModel\Rule\Collection $rules
-     * @param bool $skipValidation
-     * @param mixed $couponCode
-     * @return array
+     * @param                                        AbstractItem $item
+     * @param                                        Collection   $rules
+     * @param                                        bool         $skipValidation
+     * @param                                        mixed        $couponCode
+     * @return                                       array
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function applyRules($item, $rules, $skipValidation, $couponCode)
     {
         $address = $item->getAddress();
         $appliedRuleIds = [];
-        /* @var $rule \Magento\SalesRule\Model\Rule */
+        /* @var $rule Rule */
         foreach ($rules as $rule) {
             if (!$this->validatorUtility->canProcessRule($rule, $address)) {
                 continue;
@@ -111,8 +113,8 @@ public function applyRules($item, $rules, $skipValidation, $couponCode)
     /**
      * Add rule discount description label to address object
      *
-     * @param Address $address
-     * @param \Magento\SalesRule\Model\Rule $rule
+     * @param  Address $address
+     * @param  Rule    $rule
      * @return $this
      */
     public function addDiscountDescription($address, $rule)
@@ -142,10 +144,12 @@ public function addDiscountDescription($address, $rule)
     }
 
     /**
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
-     * @param \Magento\SalesRule\Model\Rule $rule
-     * @param \Magento\Quote\Model\Quote\Address $address
-     * @param mixed $couponCode
+     * Apply Rule
+     *
+     * @param  AbstractItem                       $item
+     * @param  Rule                               $rule
+     * @param  \Magento\Quote\Model\Quote\Address $address
+     * @param  mixed                              $couponCode
      * @return $this
      */
     protected function applyRule($item, $rule, $address, $couponCode)
@@ -160,8 +164,10 @@ protected function applyRule($item, $rule, $address, $couponCode)
     }
 
     /**
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
-     * @param \Magento\SalesRule\Model\Rule $rule
+     * Get discount Data
+     *
+     * @param  AbstractItem $item
+     * @param  Rule         $rule
      * @return \Magento\SalesRule\Model\Rule\Action\Discount\Data
      */
     protected function getDiscountData($item, $rule)
@@ -187,7 +193,7 @@ protected function getDiscountData($item, $rule)
 
     /**
      * @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
+     * @param AbstractItem                                       $item
      * @return $this
      */
     protected function setDiscountData($discountData, $item)
@@ -203,9 +209,9 @@ protected function setDiscountData($discountData, $item)
     /**
      * Set coupon code to address if $rule contains validated coupon
      *
-     * @param Address $address
-     * @param \Magento\SalesRule\Model\Rule $rule
-     * @param mixed $couponCode
+     * @param  Address $address
+     * @param  Rule    $rule
+     * @param  mixed   $couponCode
      * @return $this
      */
     public function maintainAddressCouponCode($address, $rule, $couponCode)
@@ -214,7 +220,7 @@ public function maintainAddressCouponCode($address, $rule, $couponCode)
         Rule is a part of rules collection, which includes only rules with 'No Coupon' type or with validated coupon.
         As a result, if rule uses coupon code(s) ('Specific' or 'Auto' Coupon Type), it always contains validated coupon
         */
-        if ($rule->getCouponType() != \Magento\SalesRule\Model\Rule::COUPON_TYPE_NO_COUPON) {
+        if ($rule->getCouponType() != Rule::COUPON_TYPE_NO_COUPON) {
             $address->setCouponCode($couponCode);
         }
 
@@ -224,16 +230,16 @@ public function maintainAddressCouponCode($address, $rule, $couponCode)
     /**
      * Fire event to allow overwriting of discount amounts
      *
-     * @param \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
-     * @param \Magento\SalesRule\Model\Rule $rule
-     * @param float $qty
+     * @param  \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData
+     * @param  AbstractItem                                       $item
+     * @param  Rule                                               $rule
+     * @param  float                                              $qty
      * @return $this
      */
     protected function eventFix(
         \Magento\SalesRule\Model\Rule\Action\Discount\Data $discountData,
-        \Magento\Quote\Model\Quote\Item\AbstractItem $item,
-        \Magento\SalesRule\Model\Rule $rule,
+        AbstractItem $item,
+        Rule $rule,
         $qty
     ) {
         $quote = $item->getQuote();
@@ -255,11 +261,11 @@ protected function eventFix(
     }
 
     /**
-     * @param \Magento\Quote\Model\Quote\Item\AbstractItem $item
-     * @param int[] $appliedRuleIds
+     * @param AbstractItem $item
+     * @param int[]        $appliedRuleIds
      * @return $this
      */
-    public function setAppliedRuleIds(\Magento\Quote\Model\Quote\Item\AbstractItem $item, array $appliedRuleIds)
+    public function setAppliedRuleIds(AbstractItem $item, array $appliedRuleIds)
     {
         $address = $item->getAddress();
         $quote = $item->getQuote();