MAGETWO-35141: Sequence component pull request processing

Author: valdislav

app/code/Magento/Payment/Model/InfoInterface.php

@@ -30,8 +30,8 @@ public function decrypt($data);
     /**
      * Set Additional information about payment into Payment model
      *
-     * @param mixed $key
-     * @param mixed|null $value
+     * @param string $key
+     * @param string|null $value
      * @return mixed
      */
     public function setAdditionalInformation($key, $value = null);
@@ -47,16 +47,16 @@ public function hasAdditionalInformation($key = null);
     /**
      * Unsetter for entire additional_information value or one of its element by key
      *
-     * @param string $key
+     * @param string|null $key
      * @return $this
      */
     public function unsAdditionalInformation($key = null);
 
     /**
      * Getter for entire additional_information value or one of its element by key
      *
-     * @param string $key
-     * @return array|null|mixed
+     * @param string|null $key
+     * @return mixed
      */
     public function getAdditionalInformation($key = null);
 

app/code/Magento/Payment/Test/Unit/Block/Info/CcTest.php

@@ -135,11 +135,11 @@ public function testGetCcExpDate($ccExpMonth, $ccExpYear)
         $paymentInfo
             ->expects($this->any())
             ->method('getCcExpMonth')
-            ->will($this->returnValue($ccExpMonth));
+            ->willReturn($ccExpMonth);
         $paymentInfo
             ->expects($this->any())
             ->method('getCcExpYear')
-            ->will($this->returnValue($ccExpYear));
+            ->willReturn($ccExpYear);
         $this->model->setData('info', $paymentInfo);
 
         $this->localeDate

app/code/Magento/Sales/Block/Order/PrintOrder/Creditmemo.php

@@ -127,6 +127,8 @@ public function getTotalsHtml($creditmemo)
     }
 
     /**
+     * Formats order address to html, pdf and etc. formats
+     *
      * @param \Magento\Sales\Model\Order\Address $address
      * @param string $format
      * @return null|string

app/code/Magento/Sales/Block/Order/PrintOrder/Invoice.php

@@ -127,6 +127,8 @@ public function getInvoiceTotalsHtml($invoice)
     }
 
     /**
+     * Formats order address to html, pdf and etc. formats
+     *
      * @param \Magento\Sales\Model\Order\Address $address
      * @param string $format
      * @return null|string

app/code/Magento/Sales/Model/Order/Address/Renderer.php

@@ -11,7 +11,7 @@
 use Magento\Sales\Model\Order\Address;
 
 /**
- * Class Renderer
+ * Class Renderer using for formatting of order address
  */
 class Renderer
 {
@@ -48,7 +48,8 @@ public function __construct(
      */
     public function format(Address $address, $type)
     {
-        if (!($formatType = $this->addressConfig->getFormatByCode($type)) || !$formatType->getRenderer()) {
+        $formatType = $this->addressConfig->getFormatByCode($type);
+        if (!$formatType || !$formatType->getRenderer()) {
             return null;
         }
         $this->eventManager->dispatch('customer_address_format', ['type' => $formatType, 'address' => $address]);

app/code/Magento/Sales/Model/Order/Pdf/AbstractPdf.php

@@ -404,7 +404,8 @@ protected function insertOrder(&$page, $obj, $putOrderId = true)
                     $order->getCreatedAt(),
                     true
                 ),
-                \IntlDateFormatter::MEDIUM, false
+                \IntlDateFormatter::MEDIUM,
+                false
             ),
             35,
             $top -= 15,

app/code/Magento/Sales/Model/Resource/EntityMetadata.php

@@ -8,7 +8,7 @@
 use Magento\Sales\Model\AbstractModel;
 
 /**
- * Class EntityMetadata
+ * Class EntityMetadata represents a list of entity fields that are applicable for persistence operations
  */
 class EntityMetadata
 {

app/code/Magento/Sales/Model/Resource/EntitySnapshot.php

@@ -8,7 +8,7 @@
 use Magento\Framework\Model\AbstractModel;
 
 /**
- * Class EntitySnapshot
+ * Class EntitySnapshot register snapshot of entity data, for tracking changes
  */
 class EntitySnapshot
 {

app/code/Magento/Sales/view/adminhtml/templates/order/view/info.phtml

@@ -12,7 +12,8 @@
 <?php
 $orderAdminDate = $block->formatDate(
     $block->getOrderAdminDate($_order->getCreatedAt()),
-    \IntlDateFormatter::MEDIUM, true
+    \IntlDateFormatter::MEDIUM,
+    true
 );
 $orderStoreDate = $block->formatDate(
     $block->getCreatedAtStoreDate($_order->getStore(), $_order->getCreatedAt()),

app/code/Magento/SalesSequence/Model/Config.php

@@ -6,7 +6,7 @@
 namespace Magento\SalesSequence\Model;
 
 /**
- * Class Config
+ * Class Config - configuration container for sequence
  */
 class Config
 {