MAGETWO-69036: Lazy-loaders cause fatal errors in production mode on cloud

le0n4eg · le0n4eg · commit 429558b76cfc · 2017-11-24T18:43:56.000+02:00
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/AddAttributeToTemplate.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/AddAttributeToTemplate.php
@@ -83,6 +83,7 @@ class AddAttributeToTemplate extends \Magento\Catalog\Controller\Adminhtml\Produ
      * @param Builder $productBuilder
      * @param \Magento\Framework\Controller\Result\JsonFactory $resultJsonFactory
      * @param AttributeGroupInterfaceFactory|null $attributeGroupFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Builder.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Builder.php
@@ -46,6 +46,7 @@ class Builder
      * @param Registry $registry
      * @param WysiwygModel\Config $wysiwygConfig
      * @param StoreFactory|null $storeFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         ProductFactory $productFactory,
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php
@@ -94,13 +94,13 @@ class Helper
      * @param ProductLinks $productLinks
      * @param Js $jsHelper
      * @param DateFilter $dateFilter
-     * @param LinkTypeProvider $linkTypeProvider
-     * @param CustomOptionFactory $customOptionFactory
-     * @param ProductLinkFactory $productLinkFactory
-     * @param ProductRepository $productRepository
-     * @param CustomOptionFactory $customOptionFactory
-     * @param DateTime $dateTimeFilter
-     * @param LinkResolver $linkResolver
+     * @param LinkTypeProvider|null $linkTypeProvider
+     * @param CustomOptionFactory|null $customOptionFactory
+     * @param ProductLinkFactory|null $productLinkFactory
+     * @param ProductRepository|null $productRepository
+     * @param DateTime|null $dateTimeFilter
+     * @param LinkResolver|null $linkResolver
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Catalog/Model/Product/Option/Repository.php b/app/code/Magento/Catalog/Model/Product/Option/Repository.php
@@ -58,8 +58,9 @@ class Repository implements \Magento\Catalog\Api\ProductCustomOptionRepositoryIn
      * @param \Magento\Catalog\Api\ProductRepositoryInterface $productRepository
      * @param \Magento\Catalog\Model\ResourceModel\Product\Option $optionResource
      * @param Converter $converter
-     * @param \Magento\Catalog\Model\Product\OptionFactory $optionFactory
-     * @param \Magento\Catalog\Model\ResourceModel\Product\Option\CollectionFactory $collectionFactory
+     * @param \Magento\Catalog\Model\Product\OptionFactory|null $optionFactory
+     * @param \Magento\Catalog\Model\ResourceModel\Product\Option\CollectionFactory|null $collectionFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         \Magento\Catalog\Api\ProductRepositoryInterface $productRepository,
@@ -257,6 +258,7 @@ private function getMetadataPool()
 
     /**
      * @return \Magento\Framework\EntityManager\HydratorPool
+     * @throws \RuntimeException
      * @deprecated
      */
     private function getHydratorPool()
diff --git a/app/code/Magento/Catalog/Model/ProductLink/Repository.php b/app/code/Magento/Catalog/Model/ProductLink/Repository.php
@@ -84,8 +84,9 @@ class Repository implements \Magento\Catalog\Api\ProductLinkRepositoryInterface
      * @param LinksInitializer $linkInitializer
      * @param Management $linkManagement
      * @param \Magento\Framework\Reflection\DataObjectProcessor $dataObjectProcessor
-     * @param ProductLinkInterfaceFactory $productLinkFactory
-     * @param ProductLinkExtensionFactory $productLinkExtensionFactory
+     * @param ProductLinkInterfaceFactory|null $productLinkFactory
+     * @param ProductLinkExtensionFactory|null $productLinkExtensionFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Catalog/Model/ResourceModel/Category/Flat.php b/app/code/Magento/Catalog/Model/ResourceModel/Category/Flat.php
@@ -96,8 +96,9 @@ class Flat extends \Magento\Indexer\Model\ResourceModel\AbstractResource
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Catalog\Model\Config $catalogConfig
      * @param \Magento\Framework\Event\ManagerInterface $eventManager
-     * @param string $connectionName
-     * @param CategoryFlatCollectionFactory $categoryFlatCollectionFactory
+     * @param string|null $connectionName
+     * @param CategoryFlatCollectionFactory|null $categoryFlatCollectionFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         \Magento\Framework\Model\ResourceModel\Db\Context $context,
diff --git a/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php b/app/code/Magento/Customer/Controller/Adminhtml/Index/Cart.php
@@ -57,6 +57,7 @@ class Cart extends \Magento\Customer\Controller\Adminhtml\Index
      * @param \Magento\Backend\Model\View\Result\ForwardFactory $resultForwardFactory
      * @param \Magento\Framework\Controller\Result\JsonFactory $resultJsonFactory
      * @param QuoteFactory|null $quoteFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Customer/Model/Customer/DataProvider.php b/app/code/Magento/Customer/Model/Customer/DataProvider.php
@@ -142,6 +142,7 @@ class DataProvider extends \Magento\Ui\DataProvider\AbstractDataProvider
      * @param array $data
      * @param FileProcessorFactory|null $fileProcessorFactory
      * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Customer/Model/Metadata/Form/File.php b/app/code/Magento/Customer/Model/Metadata/Form/File.php
@@ -73,6 +73,7 @@ class File extends AbstractData
      * @param Filesystem $fileSystem
      * @param UploaderFactory $uploaderFactory
      * @param FileProcessorFactory|null $fileProcessorFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php b/app/code/Magento/Directory/Model/Currency/Import/Webservicex.php
@@ -24,7 +24,7 @@ class Webservicex extends \Magento\Directory\Model\Currency\Import\AbstractImpor
     /**
      * Http Client Factory
      *
-     * @var ZendClientFactory|null
+     * @var ZendClientFactory
      */
     protected $httpClientFactory;
 
@@ -39,6 +39,7 @@ class Webservicex extends \Magento\Directory\Model\Currency\Import\AbstractImpor
      * @param \Magento\Directory\Model\CurrencyFactory $currencyFactory
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
      * @param ZendClientFactory|null $httpClientFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         \Magento\Directory\Model\CurrencyFactory $currencyFactory,
diff --git a/app/code/Magento/Downloadable/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Downloadable.php b/app/code/Magento/Downloadable/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Downloadable.php
@@ -44,10 +44,11 @@ class Downloadable
 
     /**
      * @param RequestInterface $request
-     * @param SampleFactory $sampleFactory
+     * @param SampleFactory|null $sampleFactory
      * @param SampleBuilder|null $sampleBuilder
-     * @param LinkFactory $linkFactory
+     * @param LinkFactory|null $linkFactory
      * @param LinkBuilder|null $linkBuilder
+     * @throws \RuntimeException
      */
     public function __construct(
         RequestInterface $request,
diff --git a/app/code/Magento/Indexer/Console/Command/AbstractIndexerCommand.php b/app/code/Magento/Indexer/Console/Command/AbstractIndexerCommand.php
@@ -52,6 +52,7 @@ public function __construct(
      * Returns all indexers
      *
      * @return IndexerInterface[]
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     protected function getAllIndexers()
     {
@@ -65,6 +66,7 @@ protected function getAllIndexers()
      * Gets initialized object manager
      *
      * @return ObjectManagerInterface
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     protected function getObjectManager()
     {
diff --git a/app/code/Magento/Indexer/Console/Command/AbstractIndexerManageCommand.php b/app/code/Magento/Indexer/Console/Command/AbstractIndexerManageCommand.php
@@ -49,6 +49,7 @@ public function __construct(
      * @param InputInterface $input
      * @return IndexerInterface[]
      * @throws \InvalidArgumentException
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     protected function getIndexers(InputInterface $input)
     {
@@ -107,6 +108,7 @@ public function getInputList()
     /**
      * @deprecated
      * @return mixed
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     private function getIndexerFactory()
     {
diff --git a/app/code/Magento/Quote/Model/QuoteManagement.php b/app/code/Magento/Quote/Model/QuoteManagement.php
@@ -158,6 +158,7 @@ class QuoteManagement implements \Magento\Quote\Api\CartManagementInterface
      * @param \Magento\Customer\Api\AccountManagementInterface $accountManagement
      * @param QuoteFactory $quoteFactory
      * @param QuoteIdMaskFactory|null $quoteIdMaskFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
diff --git a/app/code/Magento/Quote/Model/QuoteRepository.php b/app/code/Magento/Quote/Model/QuoteRepository.php
@@ -83,6 +83,7 @@ class QuoteRepository implements \Magento\Quote\Api\CartRepositoryInterface
      * @param \Magento\Quote\Api\Data\CartSearchResultsInterfaceFactory $searchResultsDataFactory
      * @param JoinProcessorInterface $extensionAttributesJoinProcessor
      * @param QuoteCollectionFactory|null $quoteCollectionFactory
+     * @throws \RuntimeException
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
diff --git a/lib/internal/Magento/Framework/App/Utility/Files.php b/lib/internal/Magento/Framework/App/Utility/Files.php
@@ -101,6 +101,7 @@ class Files
      * @param DirSearch $dirSearch
      * @param ThemePackageList $themePackageList
      * @param RegexIteratorFactory|null $regexIteratorFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         ComponentRegistrar $componentRegistrar,
diff --git a/setup/src/Magento/Setup/Model/SearchTermDescriptionGeneratorFactory.php b/setup/src/Magento/Setup/Model/SearchTermDescriptionGeneratorFactory.php
@@ -62,6 +62,7 @@ class SearchTermDescriptionGeneratorFactory
      * @param DescriptionGeneratorFactory|null $descriptionGeneratorFactory
      * @param DictionaryFactory|null $dictionaryFactory
      * @param SearchTermManagerFactory|null $searchTermManagerFactory
+     * @throws \RuntimeException
      */
     public function __construct(
         ObjectManagerInterface $objectManager,
