ENGCOM-4670: Small PHPDocs fixes #20295

Author: sivaschenko

app/code/Magento/Theme/Controller/Adminhtml/System/Design/Theme/UploadJs.php

@@ -4,19 +4,21 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Theme\Controller\Adminhtml\System\Design\Theme;
 
+use Magento\Framework\App\Action\HttpGetActionInterface;
+
 /**
  * Class UploadJs
  * @deprecated
  */
-class UploadJs extends \Magento\Theme\Controller\Adminhtml\System\Design\Theme
+class UploadJs extends \Magento\Theme\Controller\Adminhtml\System\Design\Theme implements HttpGetActionInterface
 {
     /**
      * Upload js file
      *
      * @return void
-     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function execute()
     {
@@ -50,6 +52,7 @@ public function execute()
                 \Magento\Framework\View\Design\Theme\Customization\File\Js::TYPE
             );
             $result = ['error' => false, 'files' => $customization->generateFileInfo($customJsFiles)];
+            // phpcs:disable Magento2.Exceptions.ThrowCatch
         } catch (\Magento\Framework\Exception\LocalizedException $e) {
             $result = ['error' => true, 'message' => $e->getMessage()];
         } catch (\Exception $e) {

app/code/Magento/Theme/Model/Design/Backend/File.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Theme\Model\Design\Backend;
 
 use Magento\Config\Model\Config\Backend\File\RequestData\RequestDataInterface;
@@ -109,10 +110,7 @@ public function beforeSave()
     }
 
     /**
-     * After Load
-     *
-     * @return File
-     * @throws LocalizedException
+     * @inheritDoc
      */
     public function afterLoad()
     {

app/code/Magento/Theme/Model/Design/Config/FileUploader/FileProcessor.php

@@ -18,6 +18,8 @@
 use Magento\Store\Model\StoreManagerInterface;
 
 /**
+ * Design file processor.
+ *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class FileProcessor
@@ -79,8 +81,8 @@ public function __construct(
      * Save file to temp media directory
      *
      * @param  string $fileId
+     *
      * @return array
-     * @throws LocalizedException
      */
     public function saveToTmp($fileId)
     {

app/code/Magento/Theme/Model/ResourceModel/Design.php

@@ -46,7 +46,7 @@ protected function _construct()
      * Perform actions before object save
      *
      * @param \Magento\Framework\Model\AbstractModel $object
-     * @return $this
+     * @return void
      * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function _beforeSave(\Magento\Framework\Model\AbstractModel $object)
@@ -152,7 +152,6 @@ protected function _checkIntersection($storeId, $dateFrom, $dateTo, $currentId)
             $dateConditions = [];
         }
 
-        $condition = '';
         if (!empty($dateConditions)) {
             $condition = '(' . implode(') OR (', $dateConditions) . ')';
             $select->where($condition);

app/code/Magento/Theme/Model/Wysiwyg/Storage.php

@@ -4,17 +4,12 @@
  * See COPYING.txt for license details.
  */
 
-/**
- * Theme wysiwyg storage model
- */
 namespace Magento\Theme\Model\Wysiwyg;
 
 use Magento\Framework\App\Filesystem\DirectoryList;
 
 /**
- * Class Storage
- *
- * @package Magento\Theme\Model\Wysiwyg
+ * Theme wysiwyg storage model
  */
 class Storage
 {
@@ -110,7 +105,7 @@ public function __construct(
      * Upload file
      *
      * @param string $targetPath
-     * @return bool
+     * @return array
      * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function uploadFile($targetPath)
@@ -271,7 +266,7 @@ public function getFilesCollection()
             if (self::TYPE_IMAGE == $storageType) {
                 $requestParams['file'] = $fileName;
                 $file['thumbnailParams'] = $requestParams;
-
+                //phpcs:ignore Generic.PHP.NoSilencedErrors
                 $size = @getimagesize($path);
                 if (is_array($size)) {
                     $file['width'] = $size[0];