MC-42158: [Improvement request] Module List Loading Taking Extremely Long

tsviklinskyi · tsviklinskyi · commit 419bbbffd376 · 2021-05-20T16:31:20.000+03:00
diff --git a/lib/internal/Magento/Framework/Module/ModuleList/Loader.php b/lib/internal/Magento/Framework/Module/ModuleList/Loader.php
@@ -208,7 +208,7 @@ private function expandSequence(
     ) {
         // Making sure we haven't already called the method for this module higher in the stack
         if (isset($accumulated[$name])) {
-            throw new \LogicException("Circular sequence reference from '{$parentName}' to '{$name}");
+            throw new \LogicException("Circular sequence reference from '{$parentName}' to '{$name}'.");
         }
         $accumulated[$name] = true;
 

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ private function expandSequence(`
`208`	`208`	`) {`
`209`	`209`	`// Making sure we haven't already called the method for this module higher in the stack`
`210`	`210`	`if (isset($accumulated[$name])) {`
`211`		`- throw new \LogicException("Circular sequence reference from '{$parentName}' to '{$name}");`
	`211`	`+ throw new \LogicException("Circular sequence reference from '{$parentName}' to '{$name}'.");`
`212`	`212`	`}`
`213`	`213`	`$accumulated[$name] = true;`
`214`	`214`