ACP2E-2978: Saving product by admin user with different role scope overwrites/deletes existing Related product information in the product

Author: glanujnehra

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -304,6 +304,12 @@ protected function setProductLinks(Product $product)
         $readonlyRelatedProducts = false;
         $readonlyUpSellProducts = false;
         foreach ($linkTypes as $linkType => $readonly) {
+            if ($linkType === 'related' && $readonly) {
+                $readonlyRelatedProducts = true;
+            }
+            if ($linkType === 'upsell' && $readonly) {
+                $readonlyUpSellProducts = true;
+            }
             if (isset($links[$linkType]) && !$readonly) {
                 foreach ((array) $links[$linkType] as $linkData) {
                     if (empty($linkData['id'])) {
@@ -319,15 +325,9 @@ protected function setProductLinks(Product $product)
                     $productLinks[] = $link;
                 }
             }
-            if ($linkType === 'related' && $readonly) {
-                $readonlyRelatedProducts = true;
-            }
-            if ($linkType === 'upsell' && $readonly) {
-                $readonlyUpSellProducts = true;
-            }
         }
         if ($readonlyRelatedProducts && $readonlyUpSellProducts && empty($productLinks)) {
-            $productLinks = $currentProductLinks;
+            return $product->setProductLinks($currentProductLinks);
         }
 
         return $product->setProductLinks($productLinks);