MC-32014: Remove google-shopping-ads module from core in 2.4.1

Author: fascinosum

app/etc/di.xml

@@ -209,6 +209,9 @@
     <preference for="Magento\Framework\MessageQueue\QueueFactoryInterface" type="Magento\Framework\MessageQueue\QueueFactory" />
     <preference for="Magento\Framework\Search\Request\IndexScopeResolverInterface" type="Magento\Framework\Indexer\ScopeResolver\IndexScopeResolver"/>
     <preference for="Magento\Framework\HTTP\ClientInterface" type="Magento\Framework\HTTP\Client\Curl" />
+    <preference for="Magento\Framework\Mview\TriggerCleanerInterface" type="\Magento\Framework\Mview\TriggerCleaner"/>
+    <preference for="Magento\Framework\Indexer\ConfigInterface" type="\Magento\Framework\Indexer\Config"/>
+    <preference for="Magento\Framework\Mview\View\State\CollectionInterface" type="Magento\Framework\Mview\View\State\Collection" />
     <type name="Magento\Framework\Model\ResourceModel\Db\TransactionManager" shared="false" />
     <type name="Magento\Framework\Acl\Data\Cache">
         <arguments>

lib/internal/Magento/Framework/Indexer/Config.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Framework\Indexer;
+
+/**
+ * Indexers configuration
+ */
+class Config implements ConfigInterface
+{
+    /**
+     * @inheritDoc
+     */
+    public function getIndexers()
+    {
+        return [];
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getIndexer($indexerId)
+    {
+        return [];
+    }
+}

lib/internal/Magento/Framework/Mview/OldViews.php renamed to lib/internal/Magento/Framework/Mview/TriggerCleaner.php

@@ -14,7 +14,7 @@
 /**
  * Class for removing old triggers that were created by mview
  */
-class OldViews
+class TriggerCleaner implements TriggerCleanerInterface
 {
     /**
      * @var CollectionFactory
@@ -47,16 +47,16 @@ public function __construct(
     }
 
     /**
-     * Unsubscribe old views by existing triggers
+     * @inheritDoc
+     * @throws \Exception
      */
-    public function unsubscribe(): void
+    public function unsubscribe(): bool
     {
         $viewCollection = $this->viewCollectionFactory->create();
         $viewList = $viewCollection->getViewsByStateMode(StateInterface::MODE_ENABLED);
 
         // Unsubscribe mviews
         foreach ($viewList as $view) {
-            /** @var ViewInterface $view */
             $view->unsubscribe();
         }
 
@@ -70,9 +70,10 @@ public function unsubscribe(): void
 
         // Re-subscribe mviews
         foreach ($viewList as $view) {
-            /** @var ViewInterface $view */
             $view->subscribe();
         }
+
+        return true;
     }
 
     /**

lib/internal/Magento/Framework/Mview/TriggerCleanerInterface.php

@@ -0,0 +1,20 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Framework\Mview;
+
+/**
+ * Service for processing of DB triggers
+ */
+interface TriggerCleanerInterface
+{
+    /**
+     * Remove the outdated trigger from the system
+     *
+     * @return bool
+     */
+    public function unsubscribe(): bool;
+}

lib/internal/Magento/Framework/Mview/View/State/Collection.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Framework\Mview\View\State;
+
+/**
+ * View state collection
+ */
+class Collection implements CollectionInterface
+{
+    /**
+     * @inheritDoc
+     */
+    public function getItems()
+    {
+        return [];
+    }
+}

setup/config/di.config.php

@@ -4,20 +4,33 @@
  * See COPYING.txt for license details.
  */
 
+use Laminas\EventManager\EventManagerInterface;
+use Laminas\ServiceManager\ServiceLocatorInterface;
+use Laminas\ServiceManager\ServiceManager;
+use Magento\Framework\Component\ComponentRegistrar;
+use Magento\Framework\Component\ComponentRegistrarInterface;
+use Magento\Framework\DB\Logger\Quiet;
+use Magento\Framework\DB\LoggerInterface;
+use Magento\Framework\Filesystem\DriverInterface;
+use Magento\Framework\Locale\Config;
+use Magento\Framework\Locale\ConfigInterface;
+use Magento\Framework\Mview\TriggerCleaner;
+use Magento\Framework\Mview\TriggerCleanerInterface;
+use Magento\Framework\Setup\Declaration\Schema\SchemaConfig;
+
 return [
     'di' => [
         'instance' => [
             'preference' => [
-                \Laminas\EventManager\EventManagerInterface::class => 'EventManager',
-                \Laminas\ServiceManager\ServiceLocatorInterface::class => \Laminas\ServiceManager\ServiceManager::class,
-                \Magento\Framework\DB\LoggerInterface::class => \Magento\Framework\DB\Logger\Quiet::class,
-                \Magento\Framework\Locale\ConfigInterface::class => \Magento\Framework\Locale\Config::class,
-                \Magento\Framework\Filesystem\DriverInterface::class =>
-                    \Magento\Framework\Filesystem\Driver\File::class,
-                \Magento\Framework\Component\ComponentRegistrarInterface::class =>
-                    \Magento\Framework\Component\ComponentRegistrar::class,
+                EventManagerInterface::class => 'EventManager',
+                ServiceLocatorInterface::class => ServiceManager::class,
+                LoggerInterface::class => Quiet::class,
+                ConfigInterface::class => Config::class,
+                DriverInterface::class => \Magento\Framework\Filesystem\Driver\File::class,
+                ComponentRegistrarInterface::class => ComponentRegistrar::class,
+                TriggerCleanerInterface::class => TriggerCleaner::class,
             ],
-            \Magento\Framework\Setup\Declaration\Schema\SchemaConfig::class => [
+            SchemaConfig::class => [
                 'parameters' => [
                     'connectionScopes' => [
                         'default',

setup/src/Magento/Setup/Model/Installer.php

@@ -25,7 +25,7 @@
 use Magento\Framework\Model\ResourceModel\Db\Context;
 use Magento\Framework\Module\ModuleList\Loader as ModuleLoader;
 use Magento\Framework\Module\ModuleListInterface;
-use Magento\Framework\Mview\OldViews;
+use Magento\Framework\Mview\TriggerCleanerInterface;
 use Magento\Framework\Setup\Declaration\Schema\DryRunLogger;
 use Magento\Framework\Setup\FilePermissions;
 use Magento\Framework\Setup\InstallDataInterface;
@@ -249,9 +249,9 @@ class Installer
     private $patchApplierFactory;
 
     /**
-     * @var OldViews
+     * @var TriggerCleanerInterface
      */
-    private $oldViews;
+    private $triggerCleaner;
 
     /**
      * Constructor
@@ -326,7 +326,7 @@ public function __construct(
         $this->componentRegistrar = $componentRegistrar;
         $this->phpReadinessCheck = $phpReadinessCheck;
         $this->schemaPersistor = $this->objectManagerProvider->get()->get(SchemaPersistor::class);
-        $this->oldViews = $this->objectManagerProvider->get()->get(OldViews::class);
+        $this->triggerCleaner = $this->objectManagerProvider->get()->get(TriggerCleanerInterface::class);
     }
 
     /**
@@ -1659,6 +1659,6 @@ private function updateColumnType(
      */
     public function removeUnusedTriggers(): void
     {
-        $this->oldViews->unsubscribe();
+        $this->triggerCleaner->unsubscribe();
     }
 }