Skip to content

Commit 413b898

Browse files
Patrick McLaindimonovp
authored andcommitted
Send order email for Braintree Paypal orders
Order emails are sent using observers on the `sales_model_service_quote_submit_success` event, but only in the `webapi_rest` and `webapi_soap` areas. When customers checkout with Braintree Paypal the order placement occurs in the `frontend` area with a request to `Magento\Braintree\Controller\Paypal\PlaceOrder`, so these orders were not sent a new order email. Fixes #13778 Fixes #12792
1 parent 447a24d commit 413b898

File tree

5 files changed

+18
-6
lines changed

5 files changed

+18
-6
lines changed

app/code/Magento/Quote/Observer/Webapi/SubmitObserver.php renamed to app/code/Magento/Quote/Observer/SubmitObserver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
namespace Magento\Quote\Observer\Webapi;
6+
namespace Magento\Quote\Observer;
77

88
use Magento\Sales\Model\Order\Email\Sender\OrderSender;
99
use Magento\Framework\Event\ObserverInterface;

app/code/Magento/Quote/Test/Unit/Observer/Webapi/SubmitObserverTest.php renamed to app/code/Magento/Quote/Test/Unit/Observer/SubmitObserverTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
namespace Magento\Quote\Test\Unit\Observer\Webapi;
6+
namespace Magento\Quote\Test\Unit\Observer;
77

88
class SubmitObserverTest extends \PHPUnit\Framework\TestCase
99
{
1010
/**
11-
* @var \Magento\Quote\Observer\Webapi\SubmitObserver
11+
* @var \Magento\Quote\Observer\SubmitObserver
1212
*/
1313
protected $model;
1414

@@ -59,7 +59,7 @@ protected function setUp()
5959
$eventMock->expects($this->once())->method('getQuote')->willReturn($this->quoteMock);
6060
$eventMock->expects($this->once())->method('getOrder')->willReturn($this->orderMock);
6161
$this->quoteMock->expects($this->once())->method('getPayment')->willReturn($this->paymentMock);
62-
$this->model = new \Magento\Quote\Observer\Webapi\SubmitObserver(
62+
$this->model = new \Magento\Quote\Observer\SubmitObserver(
6363
$this->loggerMock,
6464
$this->orderSenderMock
6565
);
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
9+
<event name="sales_model_service_quote_submit_success">
10+
<observer name="sendEmail" instance="Magento\Quote\Observer\SubmitObserver" />
11+
</event>
12+
</config>

app/code/Magento/Quote/etc/webapi_rest/events.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
99
<event name="sales_model_service_quote_submit_success">
10-
<observer name="sendEmail" instance="Magento\Quote\Observer\Webapi\SubmitObserver" />
10+
<observer name="sendEmail" instance="Magento\Quote\Observer\SubmitObserver" />
1111
</event>
1212
</config>

app/code/Magento/Quote/etc/webapi_soap/events.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
99
<event name="sales_model_service_quote_submit_success">
10-
<observer name="sendEmail" instance="Magento\Quote\Observer\Webapi\SubmitObserver" />
10+
<observer name="sendEmail" instance="Magento\Quote\Observer\SubmitObserver" />
1111
</event>
1212
</config>

0 commit comments

Comments
 (0)